Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path on Google_Service_FirebaseDynamicLinksAPI is not updated #97

Closed
giju opened this issue Dec 10, 2017 · 2 comments
Closed

Path on Google_Service_FirebaseDynamicLinksAPI is not updated #97

giju opened this issue Dec 10, 2017 · 2 comments
Assignees
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. 🚨 This issue needs some love. status: blocked Resolving the issue is dependent on other work. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@giju
Copy link

giju commented Dec 10, 2017


    $this->shortDynamicLinks = new Google_Service_FirebaseDynamicLinksAPI_Resource_ShortDynamicLinks(
        $this,
        $this->serviceName,
        'shortDynamicLinks',
        array(
          'methods' => array(
            'create' => array(
              'path' => 'v1/shortDynamicLinks', /* This path is changed wrt to new documentation
 https://firebase.google.com/docs/dynamic-links/rest*/
              'httpMethod' => 'POST',
              'parameters' => array(),
            ),
          )
        )
    );

@mattwhisenhunt
Copy link

This issue is capturing a symptom of a deeper issue #44 that different versions block changes in subsequent versions of the discovery docs.

@JustinBeckwith JustinBeckwith added triage me I really want to be triaged. 🚨 This issue needs some love. labels Jun 8, 2018
@mattwhisenhunt mattwhisenhunt added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jun 19, 2018
@JustinBeckwith JustinBeckwith removed the triage me I really want to be triaged. label Jun 19, 2018
@dwsupplee
Copy link
Contributor

I'm going to close this in favor of #44

@dwsupplee dwsupplee self-assigned this Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. 🚨 This issue needs some love. status: blocked Resolving the issue is dependent on other work. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

4 participants