Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could you please add the "trash method" of Files.php like delete method? #1481

Closed
MiguelQueiroz opened this issue Jul 12, 2018 · 3 comments
Closed
Assignees
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. status: blocked Resolving the issue is dependent on other work. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@MiguelQueiroz
Copy link

Like public function delete($fileId, $optParams = array())
{
$params = array('fileId' => $fileId);
$params = array_merge($params, $optParams);
return $this->call('delete', array($params));
}

Why not have the trash method aswell?
I know i can hack the file and do it on my own, but i think you could also add it to the source code

@mattwhisenhunt mattwhisenhunt added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. and removed type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Jul 12, 2018
@mattwhisenhunt
Copy link
Contributor

Duplicate of #1366

@mattwhisenhunt mattwhisenhunt marked this as a duplicate of #1366 Jul 12, 2018
@mattwhisenhunt mattwhisenhunt added the status: blocked Resolving the issue is dependent on other work. label Jul 12, 2018
@mattwhisenhunt
Copy link
Contributor

@MiguelQueiroz The DIY workaround is to run the generator on the v2 json file. It may require a little Python knowledge though.

@mattwhisenhunt
Copy link
Contributor

@MiguelQueiroz, I ran into this page last week: https://developers.google.com/drive/api/v3/migration
It explains why trash went away.

Looks like you can call update(['trashed'=>true])

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. status: blocked Resolving the issue is dependent on other work. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

2 participants