Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PubSub] Phpdoc for PubSubClient's constructor is incorrect #7735

Open
taka-oyama opened this issue Oct 9, 2024 · 1 comment
Open

[PubSub] Phpdoc for PubSubClient's constructor is incorrect #7735

taka-oyama opened this issue Oct 9, 2024 · 1 comment

Comments

@taka-oyama
Copy link
Contributor

taka-oyama commented Oct 9, 2024

I noticed that

* @type CacheItemPoolInterface $authCache A cache for storing access
* tokens. **Defaults to** a simple in memory implementation.

Doesn't work. It's suppose to be credentials.authCache.
I think the same thing can be said for authCacheOptions.

I'm fairly certain keyFilePath doesn't work here either.

Please take a look. Thanks.

@taka-oyama
Copy link
Contributor Author

I found a migration page that describes the changes. I guess someone forgot to update the phpdoc?

70e2265#diff-7e7a3f0069164da412cef8834788fd94cabb3d11bdd2ee31cd996bd7e23fa5f7R17-R39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant