Skip to content

Commit ed40446

Browse files
authored
chore(test): remove redundant step in test workflow (#2948)
This step is redundant now, as the yaml format and check result step is reformatted in #2920 and moved into `all_test.go`. https://github.com/googleapis/librarian/blob/7df4cf74f1d8cb5c1edddd773741c1253d8e20d4/all_test.go#L245-L257 However, the `Detect formatting changes` step is not deleted from the workflow. This causes #2933 in rare cases because test inside `cmd/doc_generate_test.go` writes to non-test file as part of the test (to verify no change). "Detect formatting changes" can kick in too soon and run into corrupt files. Fixes #2933
1 parent 8eb43f8 commit ed40446

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

.github/workflows/librarian.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,6 @@ jobs:
3636
go install golang.org/x/tools/cmd/goimports@latest
3737
- name: Run tests
3838
run: go test -race -coverprofile=coverage.out -covermode=atomic ./...
39-
- name: Detect formatting changes
40-
run: git diff --exit-code
4139
- name: Upload coverage report
4240
uses: codecov/codecov-action@v5
4341
with:

0 commit comments

Comments
 (0)