Skip to content

Commit 1c41505

Browse files
committed
style(display): rename None back to All in max columns dropdown
1 parent b6f966b commit 1c41505

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

bigframes/display/table_widget.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -115,12 +115,12 @@ function render({ model, el }) {
115115

116116
maxColumnsLabel.textContent = 'Max columns:';
117117

118-
// 0 represents "None" (all columns)
118+
// 0 represents "All" (all columns)
119119
const maxColumnOptions = [5, 10, 15, 20, 0];
120120
for (const cols of maxColumnOptions) {
121121
const option = document.createElement('option');
122122
option.value = cols;
123-
option.textContent = cols === 0 ? 'None' : cols;
123+
option.textContent = cols === 0 ? 'All' : cols;
124124

125125
const currentMax = model.get(ModelProperty.MAX_COLUMNS);
126126
// Handle None/null from python as 0/All

tests/js/table_widget.test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -444,7 +444,7 @@ describe('TableWidget', () => {
444444
expect(Number(select.value)).toBe(initialMaxColumns);
445445
});
446446

447-
it('should handle None/null initial value as 0 (None)', () => {
447+
it('should handle None/null initial value as 0 (All)', () => {
448448
model.get.mockImplementation((property) => {
449449
if (property === 'max_columns') {
450450
return null; // Python None is null in JS
@@ -456,7 +456,7 @@ describe('TableWidget', () => {
456456

457457
const select = el.querySelector('.max-columns select');
458458
expect(Number(select.value)).toBe(0);
459-
expect(select.options[select.selectedIndex].textContent).toBe('None');
459+
expect(select.options[select.selectedIndex].textContent).toBe('All');
460460
});
461461

462462
it('should update model when value changes', () => {

0 commit comments

Comments
 (0)