forked from PyCQA/mccabe
-
Notifications
You must be signed in to change notification settings - Fork 0
/
test_mccabe.py
279 lines (219 loc) · 7.81 KB
/
test_mccabe.py
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
import unittest
import sys
try:
from StringIO import StringIO
except ImportError:
from io import StringIO
import pytest
try:
import hypothesmith
from hypothesis import HealthCheck, given, settings, strategies as st
except ImportError:
hypothesmith = None
import mccabe
from mccabe import get_code_complexity
# Snippets are put outside of testcases because of spacing issue that would
# otherwise occur with triple quoted strings.
trivial = 'def f(): pass'
expr_as_statement = '''\
def f():
0xF00D
'''
sequential = """\
def f(n):
k = n + 4
s = k + n
return s
"""
sequential_unencapsulated = """\
k = 2 + 4
s = k + 3
"""
if_elif_else_dead_path = """\
def f(n):
if n > 3:
return "bigger than three"
elif n > 4:
return "is never executed"
else:
return "smaller than or equal to three"
"""
for_loop = """\
def f():
for i in range(10):
print(i)
"""
for_else = """\
def f(mylist):
for i in mylist:
print(i)
else:
print(None)
"""
recursive = """\
def f(n):
if n > 4:
return f(n - 1)
else:
return n
"""
nested_functions = """\
def a():
def b():
def c():
pass
c()
b()
"""
try_else = """\
try:
print(1)
except TypeA:
print(2)
except TypeB:
print(3)
else:
print(4)
"""
async_keywords = """\
async def foobar(a, b, c):
await whatever(a, b, c)
if await b:
pass
async with c:
pass
async for x in a:
pass
"""
annotated_assign = """\
def f():
x: Any = None
"""
def get_complexity_number(snippet, strio, max=0):
"""Get the complexity number from the printed string."""
# Report from the lowest complexity number.
get_code_complexity(snippet, max)
strio_val = strio.getvalue()
if strio_val:
return int(strio_val.split()[-1].strip("()"))
else:
return None
class McCabeTestCase(unittest.TestCase):
def setUp(self):
# If not assigned to sys.stdout then getvalue() won't capture anything.
self._orig_stdout = sys.stdout
sys.stdout = self.strio = StringIO()
def tearDown(self):
# https://mail.python.org/pipermail/tutor/2012-January/088031.html
self.strio.close()
sys.stdout = self._orig_stdout
def assert_complexity(self, snippet, max):
complexity = get_complexity_number(snippet, self.strio)
self.assertEqual(complexity, max)
# should have the same complexity when inside a function as well.
infunc = 'def f():\n ' + snippet.replace('\n', '\n ')
complexity = get_complexity_number(infunc, self.strio)
self.assertEqual(complexity, max)
def test_print_message(self):
get_code_complexity(sequential, 0)
printed_message = self.strio.getvalue()
self.assertEqual(printed_message,
"stdin:1:1: C901 'f' is too complex (1)\n")
def test_sequential_snippet(self):
complexity = get_complexity_number(sequential, self.strio)
self.assertEqual(complexity, 1)
def test_sequential_unencapsulated_snippet(self):
complexity = get_complexity_number(sequential_unencapsulated,
self.strio)
self.assertEqual(complexity, None)
def test_if_elif_else_dead_path_snippet(self):
complexity = get_complexity_number(if_elif_else_dead_path, self.strio)
# Paths that will never be executed are counted!
self.assertEqual(complexity, 3)
def test_for_loop_snippet(self):
complexity = get_complexity_number(for_loop, self.strio)
# The for loop adds an execution path; sometimes it won't be run.
self.assertEqual(complexity, 2)
def test_for_else_snippet(self):
complexity = get_complexity_number(for_else, self.strio)
# The for loop doesn't add an execution path, but its `else` does
self.assertEqual(complexity, 2)
def test_recursive_snippet(self):
complexity = get_complexity_number(recursive, self.strio)
self.assertEqual(complexity, 2)
def test_nested_functions_snippet(self):
complexity = get_complexity_number(nested_functions, self.strio)
self.assertEqual(complexity, 3)
def test_trivial(self):
"""The most-trivial program should pass a max-complexity=1 test"""
complexity = get_complexity_number(trivial, self.strio, max=1)
self.assertEqual(complexity, None)
printed_message = self.strio.getvalue()
self.assertEqual(printed_message, "")
def test_expr_as_statement(self):
complexity = get_complexity_number(expr_as_statement, self.strio)
self.assertEqual(complexity, 1)
def test_try_else(self):
self.assert_complexity(try_else, 4)
@pytest.mark.skipif(sys.version_info < (3, 5),
reason="Async keywords are only valid on Python 3.5+")
def test_async_keywords(self):
"""Validate that we properly process async keyword usage."""
complexity = get_complexity_number(async_keywords, self.strio)
self.assertEqual(complexity, 3)
@pytest.mark.skipif(
sys.version_info < (3, 6),
reason="Annotated assignments are only valid on Python 3.6+",
)
def test_annotated_assignment(self):
complexity = get_complexity_number(annotated_assign, self.strio)
self.assertEqual(complexity, 1)
class RegressionTests(unittest.TestCase):
def setUp(self):
self.original_complexity = mccabe.McCabeChecker.max_complexity
def tearDown(self):
mccabe.McCabeChecker.max_complexity = self.original_complexity
def test_max_complexity_is_always_an_int(self):
"""Ensure bug #32 does not regress."""
class _options(object):
max_complexity = None
options = _options()
options.max_complexity = '16'
self.assertEqual(0, mccabe.McCabeChecker.max_complexity)
mccabe.McCabeChecker.parse_options(options)
self.assertEqual(16, mccabe.McCabeChecker.max_complexity)
def test_get_module_complexity(self):
self.assertEqual(0, mccabe.get_module_complexity("mccabe.py"))
# This test uses the Hypothesis and Hypothesmith libraries to generate random
# syntatically-valid Python source code and applies McCabe on it.
@settings(
max_examples=1000, # roughly 1k tests/minute, or half that under coverage
derandomize=False, # deterministic mode to avoid CI flakiness
deadline=None, # ignore Hypothesis' health checks; we already know that
suppress_health_check=HealthCheck.all(), # this is slow and filter-heavy.
)
@given(
# Note that while Hypothesmith might generate code unlike that written by
# humans, it's a general test that should pass for any *valid* source code.
# (so e.g. running it against code scraped of the internet might also help)
src_contents=hypothesmith.from_grammar() | hypothesmith.from_node(),
max_complexity=st.integers(min_value=1),
)
@pytest.mark.skipif(not hypothesmith, reason="hypothesmith could not be imported")
def test_idempotent_any_syntatically_valid_python(
src_contents: str, max_complexity: int
) -> None:
"""Property-based tests for mccabe.
This test case is based on a similar test for Black, the code formatter.
Black's test was written by Zac Hatfield-Dodds, the author of Hypothesis
and the Hypothesmith tool for source code generation. You can run this
file with `python`, `pytest`, or (soon) a coverage-guided fuzzer Zac is
working on.
"""
# Before starting, let's confirm that the input string is valid Python:
compile(src_contents, "<string>", "exec") # else bug is in hypothesmith
# Then try to apply get_complexity_number to the code...
get_code_complexity(src_contents, max_complexity)
if __name__ == "__main__":
test_idempotent_any_syntatically_valid_python()
unittest.main()