build: fix lint

Signed-off-by: Carlos Alexandro Becker <[email protected]>

Author: caarlos0

.golangci.yaml

@@ -1,5 +1,5 @@
 run:
-  go: "1.21"
+  go: "1.22"
   timeout: 5m
 linters:
   enable:
@@ -14,7 +14,13 @@ linters:
     - tagliatelle
     - misspell
     - depguard
+    - testifylint
+    - gocritic
 linters-settings:
+  staticcheck:
+    checks:
+      - all
+      - "-SA1019"
   forbidigo:
     forbid:
       - 'ioutil\.*'
@@ -30,3 +36,10 @@ linters-settings:
         deny:
           - pkg: "github.com/pkg/errors"
             desc: "use stdlib instead"
+  gocritic:
+    enabled-checks:
+      - exitAfterDefer
+  testifylint:
+    enable-all: true
+    disable:
+      - error-is-as # false positive

cmd/chglog/main.go

@@ -35,7 +35,7 @@ func main() {
 		``)
 	_ = config.BindPFlag("config-file", cmdRoot.PersistentFlags().Lookup("config-file"))
 
-	cmdRoot.PersistentPreRunE = func(c *cobra.Command, args []string) error {
+	cmdRoot.PersistentPreRunE = func(*cobra.Command, []string) error {
 		if cfgFile == config.GetString("config-file") {
 			return nil
 		}

order_test.go

@@ -58,11 +58,11 @@ func (r *testRepo) modifyAndCommit(opts *git.CommitOptions) plumbing.Hash {
 	if file, err = r.Source.Filesystem.OpenFile(filename, os.O_RDWR|os.O_CREATE|os.O_APPEND, 0o666); err != nil {
 		log.Fatal(err)
 	}
-	defer file.Close()
 
-	if _, err = file.Write([]byte(fmt.Sprintf("commit %d\n", r.seqno))); err != nil {
+	if _, err = fmt.Fprintf(file, "commit %d\n", r.seqno); err != nil {
 		log.Fatal(err)
 	}
+	_ = file.Close()
 
 	if _, err = r.Source.Add(filename); err != nil {
 		log.Fatal(err)

pkg/commands/add.go

@@ -75,7 +75,7 @@ func AddCmd(config *viper.Viper) (cmd *cobra.Command) {
 		"",
 		"Footer note for this entry")
 
-	cmd.RunE = func(c *cobra.Command, args []string) (err error) {
+	cmd.RunE = func(_ *cobra.Command, args []string) (err error) {
 		var (
 			repoPath string
 			gitRepo  *git.Repository

pkg/commands/commands.go

@@ -45,7 +45,7 @@ func commonFlags(cmd *cobra.Command, config *viper.Viper) (*cobra.Command, *vipe
 		distribution,
 		`set debian distributions for`)
 
-	cmd.PreRunE = func(c *cobra.Command, args []string) error {
+	cmd.PreRunE = func(*cobra.Command, []string) error {
 		if err := config.BindPFlag("conventional-commits", cmd.Flags().Lookup("conventional-commits")); err != nil {
 			return err
 		}

pkg/commands/config.go

@@ -20,11 +20,11 @@ func ConfigCmd(config *viper.Viper) (cmd *cobra.Command) {
 		"",
 		"package name to use in formatting")
 
-	cmd.PreRunE = func(cmd *cobra.Command, args []string) error {
+	cmd.PreRunE = func(cmd *cobra.Command, _ []string) error {
 		return config.BindPFlag("package-name", cmd.Flags().Lookup("package-name"))
 	}
 
-	cmd.RunE = func(c *cobra.Command, args []string) error {
+	cmd.RunE = func(*cobra.Command, []string) error {
 		// Filter some config settings
 		cfgMap := config.AllSettings()
 		delete(cfgMap, "app")

pkg/commands/format.go

@@ -58,11 +58,11 @@ func FormatCmd(config *viper.Viper) (cmd *cobra.Command) {
 		"",
 		"custom template file to use")
 
-	cmd.PreRunE = func(cmd *cobra.Command, args []string) error {
+	cmd.PreRunE = func(cmd *cobra.Command, _ []string) error {
 		return config.BindPFlag("package-name", cmd.Flags().Lookup("package-name"))
 	}
 
-	cmd.RunE = func(c *cobra.Command, args []string) (err error) {
+	cmd.RunE = func(*cobra.Command, []string) (err error) {
 		var (
 			tpl        *template.Template
 			data       []byte

pkg/commands/init.go

@@ -31,7 +31,7 @@ func InitCmd(config *viper.Viper) (cmd *cobra.Command) {
 		"changelog.yml",
 		"file to save the new changelog to")
 
-	cmd.RunE = func(c *cobra.Command, args []string) (err error) {
+	cmd.RunE = func(_ *cobra.Command, args []string) (err error) {
 		var (
 			repoPath string
 			gitRepo  *git.Repository

pkg/commands/version.go

@@ -12,7 +12,7 @@ func VersionCmd(config *viper.Viper) (cmd *cobra.Command) {
 		Use:   "version",
 		Short: "display version info",
 	}
-	cmd.Run = func(c *cobra.Command, args []string) {
+	cmd.Run = func(*cobra.Command, []string) {
 		version := fmt.Sprintf("%s %s", config.GetString("app.name"), config.GetString("app.version"))
 		if config.GetBool("debug") {
 			version = fmt.Sprintf("%s+%s", version, config.GetString("app.commit"))