Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@UNKNOWN In Header Instead of @BUILD #663

Open
3 of 11 tasks
war59312 opened this issue Jun 27, 2024 · 10 comments
Open
3 of 11 tasks

@UNKNOWN In Header Instead of @BUILD #663

war59312 opened this issue Jun 27, 2024 · 10 comments
Labels
a:bug Something isn't working

Comments

@war59312
Copy link

Can the issue be reproduced with the latest available release? (y/n)
y

Which one is the environment gotify server is running in?

  • Docker
  • Linux machine
  • Windows machine
Docker startup command or config file here (please mask sensitive information)
Nothing special

Do you have an reverse proxy installed in front of gotify server? (Please select None if the problem can be reproduced without the presense of a reverse proxy)

  • None
  • Nginx
  • Apache
  • Caddy
Reverse proxy configuration (please mask sensitive information)
N/A

On which client do you experience problems? (Select as many as you can see)

  • WebUI
  • gotify-cli
  • Android Client
  • 3rd-party API call (Please include your code)

What did you do?
Just viewing the main page.

What did you expect to see?
The correct build number and correct link in the header

What did you see instead? (Include screenshots, android logcat/request dumps if possible)
See screenshot below. Shows @unknown in the header instead of the correct build.

image

@war59312 war59312 added the a:bug Something isn't working label Jun 27, 2024
@jmattheis
Copy link
Member

Cannot reproduce. Have you built the docker image locally?
image

@war59312
Copy link
Author

Should have said, sorry.

Running Gotify on my Synology NAS from https://registry.hub.docker.com/r/gotify/server/

Yeah having a hard time figuring out reproduction steps.

See if this works, on Windows and using edge.

Make Gotify an App. As in the 3 little dots, Apps, and "Install this site as an app"

Then pin it to the taskbar and open it from the taskbar. See if that does it.

@jmattheis
Copy link
Member

What does curl https://gotify.yourdomain.com/version return?

@war59312
Copy link
Author

The expected result of:

{"version":"2.5.0","commit":"69c939ed9410406bd57fa9cd7b2a7eae1859490d","buildDate":"2024-06-23-17:12:59"}

@jmattheis
Copy link
Member

Does it work with other browsers? Could you try deleting the gotify app created by edge and try recreating it?

@war59312
Copy link
Author

war59312 commented Jun 29, 2024

Same thing happens. But gave me an idea.

Ok indeed seems to be an issue only when using with Edge App.

And only happens if running from the taskbar or start menu icon.

If I start it within Edge, that is browse like normal to the site and then do the 3 little dots then Apps and then click on Open in Gotify We App. The version in the header loads correctly.

Seems you can just create a shortcut to duplicate the issue:

"C:\Program Files (x86)\Microsoft\Edge\Application\msedge_proxy.exe" --profile-directory=Default --app-id=jcafefepcdkedppbiekimmkcdpifhccd --app-url=https://gotify.domain.com/index.html

See it's JavaScript bringing in the version number.

When working I see:

<script type="dc7e77b5cdf9179d297a5341-text/javascript">window.config = {"register":false,"version":{"version":"2.5.0","commit":"69c939ed9410406bd57fa9cd7b2a7eae1859490d","buildDate":"2024-06-23-17:12:59"}};</script>

When broken:

<script type="70ddb18b85dd7cb7ebb26102-text/javascript">window.config = %CONFIG%;</script>

So seems %CONFIG% is not always being passed in correctly.

@jmattheis
Copy link
Member

Ahh it seems when accessing /index.html the backend doesn't correctly replace the config. Could you try creating the shortcut like this
"C:\Program Files (x86)\Microsoft\Edge\Application\msedge_proxy.exe" --profile-directory=Default --app-id=jcafefepcdkedppbiekimmkcdpifhccd --app-url=https://gotify.domain.com/

@war59312
Copy link
Author

Still unknown.

In fact it seems you can completely leave off --app-url and the shortcut still works,

Seems only cares about --app-id in reality.

@jmattheis
Copy link
Member

Could you check if the log of gotify/server includes an entry for /index.html when you open the app in edge? If yes, then #665 likely fixes the issue.

@war59312
Copy link
Author

war59312 commented Jul 2, 2024

Indeed it does. Will for sure test the next release. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:bug Something isn't working
Development

No branches or pull requests

2 participants