Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI improvments for episodelist #137

Closed
wants to merge 4 commits into from
Closed

UI improvments for episodelist #137

wants to merge 4 commits into from

Conversation

thigg
Copy link
Contributor

@thigg thigg commented Sep 19, 2020

Things done:

  • removed gpodder-ui-qml submodule (took Detach from gpodder-ui-qml #93 as hint)
  • added loading indicator to podcast list, when podcasts not yet loaded
  • persisting used filter for episodelist actually to config and using it
  • added refresh option to episodelist and added loading indicator

If accepted, the folder of the former submodule should be renamed probably.

also fixes #37

I tried to capture it a bit:

output

Thilo Kogge added 2 commits September 19, 2020 20:43
…isode list, added refresh option to episode list, persisting filter for episodelist to config, using persisted filter
@Keeper-of-the-Keys
Copy link
Contributor

Hey Thilo!
Thank you so much for all your effort.
I will make an effort to review your different PRs over the next few days (I'll try 1 every day) and then make a release.
If you can reopened your PRs that are rolled into this one that is actually better so that each PR only does a small amount of changes.
Sorry about all my delays, I had a very busy semester and a new full time job.
Thanks again!
--Keeper of the Keys

@thigg
Copy link
Contributor Author

thigg commented Sep 21, 2020

Hi Keeper,
thanks for taking your time to review.
There are no PRs that rolled into this one, but all the others are based on this one.
If I find time today besides work, I might factor out the removal of the gpodder-ui-qml submodule into a seperate PR.

I didnt refactor the submodule to a better name yet etc, because i have some general changes in mind with reorganizing the folder structure etc to make everything a bit more scoped

@thigg
Copy link
Contributor Author

thigg commented Sep 21, 2020

There is a bug with refreshing from episodelist which causes changes not to be displayed immediatley.

Its a bit hard to test, because you need new episodes in your feed... maybe something could be done with creating a local feed.

A fix would be to just listen on py.refreshing and update the whole list when its done.
Partitial updates would require some more work. (like episodes showing up on the fly, not only after whole refresh)

@thigg
Copy link
Contributor Author

thigg commented Sep 21, 2020

Oh and in this PR main.py was still in .gitignore, thus its missing. the performance PR contains a modified version of it.

@Keeper-of-the-Keys
Copy link
Contributor

Removing gpodder-ui-qml needs to be a separate affair also some of the other translation files seem to have been damaged by the IDE.
I'll try to do the removal of gpodder-ui-qml based on your work and then can you rebase your work on the master?

@sfbg
Copy link
Contributor

sfbg commented Sep 22, 2020

Persisting the Filter is absolutely great, and has been needed for a long time.

I am nit sure about the Refresh menu entry in the Episodes list, specifically the filtered. For an Episode list of a single Podcast it makes sens for sure. But what use do I have of it in the Downloaded filter for example? Actually it only makes sense in the Fresh list.

@carmenfdezb
Copy link
Contributor

I'm very sorry for the late answer. I fully agree with @sfbg, persisting used filter is really great :-O

@thigg
Copy link
Contributor Author

thigg commented Oct 2, 2020

closing in favor of the new PRs

@thigg thigg closed this Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remembering the filter choice.
4 participants