-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI improvments for episodelist #137
Conversation
…isode list, added refresh option to episode list, persisting filter for episodelist to config, using persisted filter
Hey Thilo! |
Hi Keeper, I didnt refactor the submodule to a better name yet etc, because i have some general changes in mind with reorganizing the folder structure etc to make everything a bit more scoped |
There is a bug with refreshing from episodelist which causes changes not to be displayed immediatley. Its a bit hard to test, because you need new episodes in your feed... maybe something could be done with creating a local feed. A fix would be to just listen on |
Oh and in this PR main.py was still in .gitignore, thus its missing. the performance PR contains a modified version of it. |
Removing gpodder-ui-qml needs to be a separate affair also some of the other translation files seem to have been damaged by the IDE. |
Persisting the Filter is absolutely great, and has been needed for a long time. I am nit sure about the Refresh menu entry in the Episodes list, specifically the filtered. For an Episode list of a single Podcast it makes sens for sure. But what use do I have of it in the Downloaded filter for example? Actually it only makes sense in the Fresh list. |
I'm very sorry for the late answer. I fully agree with @sfbg, persisting used filter is really great :-O |
closing in favor of the new PRs |
Things done:
If accepted, the folder of the former submodule should be renamed probably.
also fixes #37
I tried to capture it a bit: