Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[on hold] implemented a textsearchfilter for the episodelist #138

Closed
wants to merge 6 commits into from

Conversation

thigg
Copy link
Contributor

@thigg thigg commented Sep 19, 2020

fixes #42
is based on #137, thus the diff might be confusing. Can't select the PR as base.
Its all in 2b7f595

In Action:

Peek 2020-09-20 00-53

@thigg thigg mentioned this pull request Sep 20, 2020
1 task
@sfbg
Copy link
Contributor

sfbg commented Sep 21, 2020

@thigg @Keeper-of-the-Keys tbh, I do not know if this feature is that useful. Especially as a dedicated filter. Perhaps search right in the episodes list, instead?

As I have mentioned elsewhere, filtering by pulling, then selecting is very cumbersome in my opinion.

@thigg
Copy link
Contributor Author

thigg commented Sep 21, 2020

Im not using the search very often. Because of that a permanent searchbar seems a bit like a waste of screenspace to me.

Having all the filters directly in the pulley do make the pulley very long (which might not be a problem, would have to try).
Also the "refresh podcasts"-item would be strange mixed up with the filters.

My personal workflow with the app is usually having the filtered episodelist open and refreshing the list about twice a day, thus having the refresh action easily accessible from the episodelist seems very practical to me.

Maybe we could put a toolbar on top/bottom which allows search/filter/updating in one element?
Maybe it could just be there where the current filter is now shown?

@thigg
Copy link
Contributor Author

thigg commented Oct 2, 2020

postponed until the other PRs are merged, leaving it open for now for reference. This needs to be rebased on the current master

@thigg thigg changed the title implemented a textsearchfilter for the episodelist [on hold] implemented a textsearchfilter for the episodelist Oct 2, 2020
@Keeper-of-the-Keys
Copy link
Contributor

@thigg @Keeper-of-the-Keys tbh, I do not know if this feature is that useful. Especially as a dedicated filter. Perhaps search right in the episodes list, instead?

As I have mentioned elsewhere, filtering by pulling, then selecting is very cumbersome in my opinion.

Text search would be cool, the exact UX we'll probably need to figure out and polish.

@thigg I'm closing this PR since it is too extensive to review in decent time, feel free to submit a cleaner PR that does only one feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request] podcast episode search/filter
3 participants