Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No description available for feed #1566

Open
chriad opened this issue Oct 8, 2023 · 1 comment · May be fixed by gpodder/podcastparser#47
Open

No description available for feed #1566

chriad opened this issue Oct 8, 2023 · 1 comment · May be fixed by gpodder/podcastparser#47

Comments

@chriad
Copy link

chriad commented Oct 8, 2023

gPodder 3.11.3 (2023-09-30) installed via flathub
Ubuntu 23.04

No description is shown for the following feed:

https://www.hoerspielundfeature.de/krimi-hoerspiel-100.xml

However the xml document does contain descriptions.

Here is an example entry:

<item>
    <title>Professor van Dusen im Wilden Westen - Professor van Dusen | Folge 36</title>
    <link>https://www.hoerspielundfeature.de/van-dusen-folge-36-100.html</link>
    <description>
        <![CDATA[<img src="https://bilder.deutschlandfunk.de/83/a9/13/70/83a91370-b258-439e-a10a-72ae035640d8/van-dusen-im-wilden-westen-100-2400x1350.jpg?t=1695208652670" alt="Ein Kaktus vor einem Handkarren aus Holz vor einer Wild-West-Kulisse." title="Ein Kaktus vor einem Handkarren aus Holz vor einer Wild-West-Kulisse."
            width="144" height="81" border="0" align="left" hspace="4" vspace="4"/>Im Jahr 1902 treffen Professor van Dusen und sein Begleiter Hatch in Santa Fé ein. Sie sind auf der Suche nach dem Erfinder Thomas Alva Edison. Dieser ist verschwunden: Seine Fußspuren enden unvermittelt vor einem Salzsee. Hat er sich Luft aufgelöst?<br clear="all"/><br/>Von Michael Koser<br/>www.deutschlandfunkkultur.de, Kriminalhörspiel<br/><a title="Direkter Link zur Audiodatei" href="https://podcast-mp3.dradio.de/podcast/2023/09/25/pvd_folge_36_professor_van_dusen_im_wilden_westen_drk_20230925_2230_77520053.mp3?refId=krimi-hoerspiel-100">Direkter Link zur Audiodatei</a><br/><p><br/></p>]]>
    </description>
    <content:encoded>
        <![CDATA[]]>
    </content:encoded>
    <guid>https://podcast-mp3.dradio.de/podcast/2023/09/25/pvd_folge_36_professor_van_dusen_im_wilden_westen_drk_20230925_2230_77520053.mp3?refId=krimi-hoerspiel-100</guid>
    <pubDate>Mon, 25 Sep 2023 22:30:00 +0200</pubDate>
    <enclosure url="https://podcast-mp3.dradio.de/podcast/2023/09/25/pvd_folge_36_professor_van_dusen_im_wilden_westen_drk_20230925_2230_77520053.mp3?refId=krimi-hoerspiel-100" length="54689311" type="audio/mpeg" />
    <itunes:author></itunes:author>
    <itunes:duration>56:55</itunes:duration>
</item>

I searched for CDATA in the issues. To my best understanding the 2 resulting issues are not related to this.

Is this a limitation of gpodder or a misconfiguration/non-standard-compliance of the feed?

Thank you
@auouymous
Copy link
Member

gPodder uses podcastparser to parse the feeds, and it uses the following lines to get a description:

    'rss/channel/item/description': RSSItemDescription(),
    'rss/channel/item/content:encoded': EpisodeAttr('description_html'),

The problem is that the feed contains both of those:

  <description>
    <![CDATA[...a bunch of html...]]>
  </description>
  <content:encoded>
    <![CDATA[]]>
  </content:encoded>

Podcastparser sees the <description> and sets description_html to the html there, then it sees the <content:encoded> and clears description_html, because the CDATA is empty.

I will see about having podcastparser not overwrite a non-empty field with an empty one.

auouymous added a commit to auouymous/podcastparser that referenced this issue Oct 10, 2023
@auouymous
Don't overwrite non-empty fields with empty fields.
7270079 
Fixes gpodder/gpodder#1566.
@auouymous auouymous linked a pull request Oct 10, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't overwrite non-empty fields with empty fields. auouymous/podcastparser
2 participants
@chriad @auouymous