Skip to content

Commit cc8ddbd

Browse files
committed
[GR-69773] Allow explicitly specifying jdkDependent attribute on distributions.
PullRequest: mx/1967
2 parents dc728ea + 066573e commit cc8ddbd

File tree

4 files changed

+32
-9
lines changed

4 files changed

+32
-9
lines changed

ci/common.jsonnet

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -323,6 +323,24 @@ local common_json = import "../common.json";
323323
},
324324
},
325325

326+
wasm_ol8:: {
327+
downloads+: {
328+
WABT_DIR: {name: 'wabt', version: '1.0.36-ol8', platformspecific: true},
329+
},
330+
environment+: {
331+
WABT_DIR: '$WABT_DIR/bin',
332+
},
333+
},
334+
335+
emsdk_ol8:: {
336+
downloads+: {
337+
EMSDK_DIR: {name: 'emsdk', version: '4.0.10', platformspecific: true},
338+
},
339+
environment+: {
340+
EMCC_DIR: '$EMSDK_DIR/upstream/emscripten/'
341+
}
342+
},
343+
326344
fastr:: {
327345
# Note: On both Linux and MacOS, FastR depends on the gnur module and on gfortran
328346
# of a specific version (4.8.5 on Linux, 10.2.0 on MacOS)

common.json

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -52,15 +52,15 @@
5252
"labsjdk-ee-25": {"name": "labsjdk", "version": "ee-25+30-jvmci-b01", "platformspecific": true },
5353
"labsjdk-ee-25Debug": {"name": "labsjdk", "version": "ee-25+30-jvmci-b01-debug", "platformspecific": true },
5454
"labsjdk-ee-25-llvm": {"name": "labsjdk", "version": "ee-25+30-jvmci-b01-sulong", "platformspecific": true },
55-
"graalvm-ee-25-ea": {"name": "graalvm-jdk", "version": "25.0.0", "ea": "33", "platformspecific": true },
55+
"graalvm-ee-25-ea": {"name": "graalvm-jdk", "version": "25.0.0", "ea": "36", "platformspecific": true },
5656

57-
"oraclejdk-latest": {"name": "jpg-jdk", "version": "26", "build_id": "jdk-26+12", "platformspecific": true, "extrabundles": ["static-libs"]},
58-
"labsjdk-ce-latest": {"name": "labsjdk", "version": "ce-26+12-jvmci-b01", "platformspecific": true },
59-
"labsjdk-ce-latestDebug": {"name": "labsjdk", "version": "ce-26+12-jvmci-b01-debug", "platformspecific": true },
60-
"labsjdk-ce-latest-llvm": {"name": "labsjdk", "version": "ce-26+12-jvmci-b01-sulong", "platformspecific": true },
61-
"labsjdk-ee-latest": {"name": "labsjdk", "version": "ee-26+12-jvmci-b01", "platformspecific": true },
62-
"labsjdk-ee-latestDebug": {"name": "labsjdk", "version": "ee-26+12-jvmci-b01-debug", "platformspecific": true },
63-
"labsjdk-ee-latest-llvm": {"name": "labsjdk", "version": "ee-26+12-jvmci-b01-sulong", "platformspecific": true }
57+
"oraclejdk-latest": {"name": "jpg-jdk", "version": "26", "build_id": "jdk-26+13", "platformspecific": true, "extrabundles": ["static-libs"]},
58+
"labsjdk-ce-latest": {"name": "labsjdk", "version": "ce-26+13-jvmci-b01", "platformspecific": true },
59+
"labsjdk-ce-latestDebug": {"name": "labsjdk", "version": "ce-26+13-jvmci-b01-debug", "platformspecific": true },
60+
"labsjdk-ce-latest-llvm": {"name": "labsjdk", "version": "ce-26+13-jvmci-b01-sulong", "platformspecific": true },
61+
"labsjdk-ee-latest": {"name": "labsjdk", "version": "ee-26+13-jvmci-b01", "platformspecific": true },
62+
"labsjdk-ee-latestDebug": {"name": "labsjdk", "version": "ee-26+13-jvmci-b01-debug", "platformspecific": true },
63+
"labsjdk-ee-latest-llvm": {"name": "labsjdk", "version": "ee-26+13-jvmci-b01-sulong", "platformspecific": true }
6464
},
6565

6666
"eclipse": {

src/mx/_impl/mx.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4852,6 +4852,7 @@ class Distribution(Dependency):
48524852
is defined by the `Distribution` subclasses.
48534853
:param list excludedLibs: libraries whose contents should be excluded from this distribution's built artifact
48544854
:param bool platformDependent: specifies if the built artifact is platform dependent
4855+
:param bool jdkDependent: specifies if the built artifact is JDK dependent
48554856
:param str theLicense: license applicable when redistributing the built artifact of the distribution
48564857
"""
48574858
def __init__(self, suite, name, deps, excludedLibs, platformDependent, theLicense, testDistribution=False, platforms=None, **kwArgs):
@@ -4860,6 +4861,7 @@ def __init__(self, suite, name, deps, excludedLibs, platformDependent, theLicens
48604861
self.update_listeners = set()
48614862
self.excludedLibs = excludedLibs
48624863
self.platformDependent = platformDependent
4864+
self.jdkDependent = kwArgs.pop('jdkDependent', None)
48634865
if platforms == 'local':
48644866
self.platforms = [None]
48654867
self.local_platform_only = True
@@ -4881,6 +4883,9 @@ def is_test_distribution(self):
48814883
def isPlatformDependent(self):
48824884
return self.platformDependent
48834885

4886+
def isJDKDependent(self):
4887+
return self.jdkDependent
4888+
48844889
def add_update_listener(self, listener):
48854890
self.update_listeners.add(listener)
48864891

src/mx/mx_version.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
# The version must be updated for every PR (checked in CI) and the comment should reflect the PR's issue
2-
version = "7.60.3" # GR-69120: mx profrecord should not mask failures of the recorded process
2+
version = "7.61.0" # GR-69773 jdkDependent distributions

0 commit comments

Comments
 (0)