Avoid adding duplicated junit entries on classpath

Author: dnestoro

common/junit-platform-native/build.gradle

@@ -52,12 +52,16 @@ maven {
 }
 dependencies {
     compileOnly libs.graalvm.svm
-    implementation(platform(libs.test.junit.bom))
-    implementation libs.test.junit.platform.console
-    implementation libs.test.junit.platform.launcher
-    implementation libs.test.junit.jupiter.core
+    compileOnly(platform(libs.test.junit.bom))
+    compileOnly libs.test.junit.platform.console
+    compileOnly libs.test.junit.platform.launcher
+    compileOnly libs.test.junit.jupiter.core
     testImplementation libs.test.junit.vintage
+
+    testRuntimeOnly(platform(libs.test.junit.bom))
+    testRuntimeOnly libs.test.junit.platform.console
     testRuntimeOnly libs.test.junit.platform.launcher
+    testRuntimeOnly libs.test.junit.jupiter.core
 }
 
 apply from: "gradle/native-image-testing.gradle"

common/junit-platform-native/src/main/java/org/graalvm/junit/platform/NativeImageJUnitLauncher.java

@@ -123,12 +123,12 @@ public static void main(String... args) {
             out.println("JUnit Platform on Native Image - report");
             out.println("----------------------------------------\n");
             out.flush();
-            launcher.registerTestExecutionListeners(new PrintTestExecutionListener(out));
+            configurePrintTestExecutionListener(launcher, out);
         }
 
         SummaryGeneratingListener summaryListener = new SummaryGeneratingListener();
         launcher.registerTestExecutionListeners(summaryListener);
-        launcher.registerTestExecutionListeners(new LegacyXmlReportGeneratingListener(Paths.get(xmlOutput), out));
+        configureLegacyXMLReport(launcher, xmlOutput, out);
         launcher.execute(testPlan);
 
         TestExecutionSummary summary = summaryListener.getSummary();
@@ -271,4 +271,21 @@ private static boolean testIdsDirectoryExists(Path directory) {
         return directory != null && Files.exists(directory);
     }
 
+
+    private static void configurePrintTestExecutionListener(Launcher launcher, PrintWriter out) {
+        try {
+            Class.forName("org.junit.platform.reporting.legacy.LegacyReportingUtils");
+            launcher.registerTestExecutionListeners(new PrintTestExecutionListener(out));
+        } catch (NoClassDefFoundError | ClassNotFoundException e) {
+            // intentionally ignored
+        }
+    }
+
+    private static void configureLegacyXMLReport(Launcher launcher, String xmlOutput, PrintWriter out) {
+        try {
+            launcher.registerTestExecutionListeners(new LegacyXmlReportGeneratingListener(Paths.get(xmlOutput), out));
+        } catch (NoClassDefFoundError e) {
+            // intentionally ignored
+        }
+    }
 }

native-maven-plugin/src/main/java/org/graalvm/buildtools/maven/NativeTestMojo.java

@@ -63,7 +63,13 @@
 import org.graalvm.buildtools.utils.FileUtils;
 import org.graalvm.buildtools.utils.JUnitUtils;
 import org.graalvm.buildtools.utils.NativeImageConfigurationUtils;
+import org.w3c.dom.Document;
+import org.xml.sax.SAXException;
 
+import javax.xml.parsers.DocumentBuilder;
+import javax.xml.parsers.DocumentBuilderFactory;
+import javax.xml.parsers.ParserConfigurationException;
+import java.io.File;
 import java.io.IOException;
 import java.io.UncheckedIOException;
 import java.nio.file.Files;
@@ -135,6 +141,8 @@ protected void addDependenciesToClasspath() throws MojoExecutionException {
             .filter(it -> it.getGroupId().startsWith(NativeImageConfigurationUtils.MAVEN_GROUP_ID) || it.getGroupId().startsWith("org.junit"))
             .map(it -> it.getFile().toPath())
             .forEach(imageClasspath::add);
+
+        modules.addAll(collectJUnitModulesAlreadyOnClasspath());
         var jars = findJunitPlatformNativeJars(modules);
         imageClasspath.addAll(jars);
     }
@@ -310,6 +318,51 @@ private List<Path> findJunitPlatformNativeJars(Set<Module> modulesAlreadyOnClass
             .collect(Collectors.toList());
     }
 
+    private Set<Module> collectJUnitModulesAlreadyOnClasspath() {
+        Set<Module> artifacts = new HashSet<>();
+        for (Path entry : imageClasspath) {
+            if (isJUnitArtifact(entry)) {
+                File pom = getArtifactPOM(entry);
+                if (pom != null) {
+                    artifacts.add(getModuleFromPOM(pom));
+                }
+            }
+        }
+
+        return artifacts;
+    }
+
+    private boolean isJUnitArtifact(Path entry) {
+        return entry.toString().contains("junit");
+    }
+
+    private File getArtifactPOM(Path classpathEntry) {
+        List<File> artifactContent = getArtifactContent(classpathEntry.getParent());
+        List<File> candidates = artifactContent.stream().filter(f -> f.getName().endsWith(".pom")).collect(Collectors.toList());
+        return candidates.size() != 1 ? null : candidates.get(0);
+    }
+
+    private List<File> getArtifactContent(Path path) {
+        File[] content = path.toFile().listFiles();
+        return content == null ? List.of() : List.of(content);
+    }
+
+    private Module getModuleFromPOM(File pom) {
+        try {
+            DocumentBuilderFactory factory = DocumentBuilderFactory.newInstance();
+            factory.setIgnoringElementContentWhitespace(true);
+            DocumentBuilder builder = factory.newDocumentBuilder();
+            Document doc = builder.parse(pom);
+
+            String groupId = doc.getElementsByTagName("groupId").item(0).getFirstChild().getTextContent();
+            String artifactId = doc.getElementsByTagName("artifactId").item(0).getFirstChild().getTextContent();
+
+            return new Module(groupId, artifactId);
+        } catch (ParserConfigurationException | IOException | SAXException e) {
+            throw new RuntimeException("Cannot get maven coordinates from " + pom.getPath() + ". Reason: " + e.getMessage());
+        }
+    }
+
     private static final class Module {
         private final String groupId;
         private final String artifactId;