0.11.0 fails with java.lang.NoClassDefFoundError: org/junit/jupiter/params/provider/ArgumentsSource

[yschimke]

Gradle build failing on test compile

See square/okhttp#8947

Build https://github.com/square/okhttp/actions/runs/16386453920/job/46306645418?pr=8947

full error

Error: Feature defined by org.graalvm.junit.platform.JUnitPlatformFeature unexpectedly failed with a(n) java.lang.NoClassDefFoundError. Please report this problem to the authors of org.graalvm.junit.platform.JUnitPlatformFeature.
Caused by: java.lang.NoClassDefFoundError: org/junit/jupiter/params/provider/ArgumentsSource
	at org.graalvm.junit.platform.config.jupiter.JupiterConfigProvider.onTestClassRegistered(JupiterConfigProvider.java:81)
	at org.graalvm.junit.platform.JUnitPlatformFeature.lambda$registerTestClassesForReflection$2(JUnitPlatformFeature.java:161)
	at org.graalvm.junit.platform.JUnitPlatformFeature.forEachProvider(JUnitPlatformFeature.java:179)
	at org.graalvm.junit.platform.JUnitPlatformFeature.lambda$registerTestClassesForReflection$3(JUnitPlatformFeature.java:161)
	at org.graalvm.junit.platform.TestClassRegistrar.registerTestClassForReflection(TestClassRegistrar.java:62)
	at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184)
	at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:215)
	at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:215)

[dnestoro]

Hi @yschimke, can you please provide a minimal reproducer for this issue so I can investigate locally?

[yschimke]

@dnestoro yep - I'll try to next weekend.

[yschimke]

Until then I tried simplifying the current test but even this fails

import assertk.assertThat
import assertk.assertions.isEqualTo
import kotlin.test.Test

class SampleTest {
  @Test
  fun passingTest() {
    assertThat("hello").isEqualTo("hello")
  }
}

with this debug logging

[Debug] [Native Image Configuration] Failed to resolve: org.junit.jupiter.engine.extension.TimeoutExtension$ExecutorResource Reason: java.lang.ClassNotFoundException: org.junit.jupiter.engine.extension.TimeoutExtension$ExecutorResource
[Debug] [Native Image Configuration] Registering for reflection: org.junit.jupiter.engine.extension.TimeoutInvocationFactory$SingleThreadExecutorResource
[1/8] Initializing...                                                                                    (5.8s @ 0.18GB)
 Java version: 23.0.1+11, vendor version: Oracle GraalVM 23.0.1+11.1
 Graal compiler: optimization level: b, target machine: x86-64-v3, PGO: off
 C compiler: cl.exe (microsoft, x64, 19.38.33134)
 Garbage collector: Serial GC (max heap size: 80% of RAM)
 3 user-specific feature(s):
 - com.oracle.svm.thirdparty.gson.GsonFeature
 - okhttp3.internal.graal.OkHttpFeature
 - org.graalvm.junit.platform.JUnitPlatformFeature
------------------------------------------------------------------------------------------------------------------------
Build resources:
 - 24.12GB of memory (75.6% of 31.93GB system memory, determined at start)
 - 24 thread(s) (100.0% of 24 available processor(s), determined at start)
[junit-platform-native] Running in 'test listener' mode using files matching pattern [junit-platform-unique-ids*] found in folder [C:\Users\yuri\workspace\okhttp\native-image-tests\build\test-results\test\testlist] and its subfolders.
[Debug] Registering test class for reflection: okhttp3.nativeimage.SampleTest
[Debug] [Native Image Configuration] Registering for reflection: okhttp3.nativeimage.SampleTest

Error: Feature defined by org.graalvm.junit.platform.JUnitPlatformFeature unexpectedly failed with a(n) java.lang.NoClassDefFoundError. Please report this problem to the authors of org.graalvm.junit.platform.JUnitPlatformFeature.
Caused by: java.lang.NoClassDefFoundError: org/junit/jupiter/params/provider/ArgumentsSource
	at org.graalvm.junit.platform.config.jupiter.JupiterConfigProvider.onTestClassRegistered(JupiterConfigProvider.java:81)
	at org.graalvm.junit.platform.JUnitPlatformFeature.lambda$registerTestClassesForReflection$2(JUnitPlatformFeature.java:161)
	at org.graalvm.junit.platform.JUnitPlatformFeature.forEachProvider(JUnitPlatformFeature.java:179)
	at org.graalvm.junit.platform.JUnitPlatformFeature.lambda$registerTestClassesForReflection$3(JUnitPlatformFeature.java:161)
	at org.graalvm.junit.platform.TestClassRegistrar.registerTestClassForReflection(TestClassRegistrar.java:62)
	at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184)
	at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:215)
	at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:215)

I'll continue next weekend.

[dnestoro]

@marcphilipp has ArgumentsSource class changed its location (package) in the JUnit project between versions? The error suggests that the class (which is there for over 4 years) can't be found.

This can be related to the fact that we removed duplicated JUnit classpath entries (this PR) and that in the previous versions we were able to find this class in the duplicates that are not on the classpath anymore. Without debugging some reproducer, I don't see other reason why the class is missing.

If the reason is really that this class is missing in some JUnit version, the easiest fix will be if we just move ArgumentsSource registration in the try-catch block (the same way we did for FieldSource). I just want to verify what caused this problem in the first place, so that we really fix the problem and not just hide it.

[marcphilipp]

@marcphilipp has ArgumentsSource class changed its location (package) in the JUnit project between versions? The error suggests that the class (which is there for over 4 years) can't be found.

No, it has not changed location.

Looks like JupiterConfigProvider is expecting junit-jupiter-api and junit-jupiter-params to be on the classpath but from the test in #745 (comment) it seems kotlin-test is being used. Therefore, I think JupiterConfigProvider must be changed to only only register those classes if the relevant jars are actually on the classpath.

[yschimke]

That probably explains and fixes my issue, let me try switching to jupiter API.

But I would expect it not to fail in this feature.

[yschimke]

let me try switching to jupiter API

I already have another test using jupiter, so I assume it's just because I wasn't using ArgumentsProvider.

[yschimke]

Now passing, but I think there is still a bug to fix here.

> Task :native-image-tests:nativeTest
[junit-platform-native] Running in 'test listener' mode using files matching pattern [junit-platform-unique-ids*] found in folder [/home/runner/work/okhttp/okhttp/native-image-tests/build/test-results/test/testlist] and its subfolders.
JUnit Platform on Native Image - report
----------------------------------------

okhttp3.nativeimage.PublicSuffixDatabaseTest > testResourcesLoaded() SUCCESSFUL

okhttp3.nativeimage.SampleTest > testExternalSite() SUCCESSFUL

okhttp3.nativeimage.SampleTest > testMockWebServer() SUCCESSFUL

okhttp3.nativeimage.SampleTest > passingTest() SUCCESSFUL

okhttp3.nativeimage.WithArgumentSourceTest > [1] 1 SUCCESSFUL

okhttp3.nativeimage.WithArgumentSourceTest > [2] 2 SUCCESSFUL


Test run finished after 50 ms
[         6 containers found      ]
[         0 containers skipped    ]
[         6 containers started    ]
[         0 containers aborted    ]
[         6 containers successful ]
[         0 containers failed     ]
[         6 tests found           ]
[         0 tests skipped         ]
[         6 tests started         ]
[         0 tests aborted         ]
[         6 tests successful      ]
[         0 tests failed          ]

[yschimke]

I guess this can be closed if #747 is tracking it.

[dnestoro]

@yschimke thanks for reporting this issue. This PR should fix the problem: #752

@marcphilipp thanks for your input!