Incompatibility with 'application' plugin; startup scripts no longer executable

[cloudshiftchris]

When applied with the application plugin the startup scripts (via distZip task) no longer have executable bit set.

[jjohannes]

Thank you for opening the issue @cloudshiftchris.

@britter already brought this up, but we forgot to create an issue here.

[britter]

Yeah, I think we can be more clever in preserving the execute permissions for some files. We could react to the presence of the application plugin and find the scripts it creates. We could also look for well known file extensions such as .sh or .bat. Finally we could inspect files to see whether they start with a shebang line.

[cloudshiftchris]

I'd assumed (incorrectly) that CopySpec would use the permissions as 'defaults' if nothing more specific (i.e. child copy specs, etc) were provided.
Ideally we'd find a way to provide defaults such that we don't fall back to OS-inconsistent ones.

[jjohannes]

For the start scripts, the permission is set to a fixed value by the application plugin:
https://github.com/gradle/gradle/blob/7f6e34676041df34961420edd3cf95e6b7b9f762/platforms/jvm/plugins-application/src/main/java/org/gradle/api/plugins/ApplicationPlugin.java#L229

Which means that these archive entries are already reproducible.

The best solution would be to not override this, but only set permissions for all other files (for which no default/convention exists).