Skip to content

Commit fbe77d7

Browse files
authored
Validations Fixes | SIS-189 (#107)
* NotEmpty Annotation Has Been Added to StudentLessonRegistrationInfoRequest/lessonsIds Field * NotEmpty Annotation Has Been Added to StudentsLessonAbsenteeismUpdateRequest/absenteeismIdsAndTheoreticalHoursAndPracticeHours Field * NotNull Annotation Has Been Added to StudentLessonAbsenteeismSaveRequest/operationInfoRequest and StudentsLessonAbsenteeismUpdateRequest/operationInfoRequest Fields * NotNull Annotation Has Been Added to FeatureToggleRequest/operationInfoRequest Field * NotNull Annotation Has Been Added to operationInfoRequest Field in StudentGraduationSaveRequest, StudentGraduationApproveRequest, StudentGraduationConfirmRequest, StudentGraduationRejectRequest ve StudentGraduationUnconfirmRequest Classes * NotNull Annotation Has Been Added to operationInfoRequest Field in StudentLessonNoteSaveRequest, StudentsLessonFinalNotesConfirmRequest, StudentsLessonMidtermNotesConfirmRequest, StudentsLessonNoteStatusUpdateRequest and StudentsLessonResitNotesConfirmRequest Classes * NotNull Annotation Has Been Added to operationInfoRequest Field in StudentsLessonFinalNotesUpdateRequest, StudentsLessonMidtermNotesUpdateRequest and StudentsLessonResitNotesUpdateRequest Classes * NotNull Annotation Has Been Added to finalNoteIdsAndNotes Field in StudentsLessonFinalNotesUpdateRequest Class * NotNull Annotation Has Been Added to midtermNoteIdsAndNotes Field in StudentsLessonMidtermNotesUpdateRequest Class * NotNull Annotation Has Been Added to resitNoteIdsAndNotes Field in StudentsLessonResitNotesUpdateRequest Class
1 parent 27d27cd commit fbe77d7

17 files changed

+26
-0
lines changed

src/main/java/com/graduationproject/studentinformationsystem/university/absenteeism/model/dto/request/StudentLessonAbsenteeismSaveRequest.java

+1
Original file line numberDiff line numberDiff line change
@@ -41,5 +41,6 @@ public class StudentLessonAbsenteeismSaveRequest implements Serializable {
4141
private Integer maxPracticeHours;
4242

4343
@Valid
44+
@NotNull
4445
private SisOperationInfoRequest operationInfoRequest;
4546
}

src/main/java/com/graduationproject/studentinformationsystem/university/absenteeism/model/dto/request/StudentsLessonAbsenteeismUpdateRequest.java

+3
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
import lombok.Getter;
55

66
import javax.validation.Valid;
7+
import javax.validation.constraints.NotEmpty;
78
import javax.validation.constraints.NotNull;
89
import java.io.Serial;
910
import java.io.Serializable;
@@ -16,8 +17,10 @@ public class StudentsLessonAbsenteeismUpdateRequest implements Serializable {
1617
private static final long serialVersionUID = -4786087456831453643L;
1718

1819
@NotNull
20+
@NotEmpty
1921
private Map<String, Map<String, Integer>> absenteeismIdsAndTheoreticalHoursAndPracticeHours;
2022

2123
@Valid
24+
@NotNull
2225
private SisOperationInfoRequest operationInfoRequest;
2326
}

src/main/java/com/graduationproject/studentinformationsystem/university/featuretoggle/model/dto/request/FeatureToggleRequest.java

+1
Original file line numberDiff line numberDiff line change
@@ -19,5 +19,6 @@ public class FeatureToggleRequest implements Serializable {
1919
private FeatureToggleName name;
2020

2121
@Valid
22+
@NotNull
2223
private SisOperationInfoRequest operationInfoRequest;
2324
}

src/main/java/com/graduationproject/studentinformationsystem/university/graduation/model/dto/request/StudentGraduationApproveRequest.java

+1
Original file line numberDiff line numberDiff line change
@@ -18,5 +18,6 @@ public class StudentGraduationApproveRequest implements Serializable {
1818
private String graduationId;
1919

2020
@Valid
21+
@NotNull
2122
private SisOperationInfoRequest operationInfoRequest;
2223
}

src/main/java/com/graduationproject/studentinformationsystem/university/graduation/model/dto/request/StudentGraduationConfirmRequest.java

+1
Original file line numberDiff line numberDiff line change
@@ -18,5 +18,6 @@ public class StudentGraduationConfirmRequest implements Serializable {
1818
private String graduationId;
1919

2020
@Valid
21+
@NotNull
2122
private SisOperationInfoRequest operationInfoRequest;
2223
}

src/main/java/com/graduationproject/studentinformationsystem/university/graduation/model/dto/request/StudentGraduationRejectRequest.java

+1
Original file line numberDiff line numberDiff line change
@@ -18,5 +18,6 @@ public class StudentGraduationRejectRequest implements Serializable {
1818
private String graduationId;
1919

2020
@Valid
21+
@NotNull
2122
private SisOperationInfoRequest operationInfoRequest;
2223
}

src/main/java/com/graduationproject/studentinformationsystem/university/graduation/model/dto/request/StudentGraduationSaveRequest.java

+1
Original file line numberDiff line numberDiff line change
@@ -20,5 +20,6 @@ public class StudentGraduationSaveRequest implements Serializable {
2020
private Long studentId;
2121

2222
@Valid
23+
@NotNull
2324
private SisOperationInfoRequest operationInfoRequest;
2425
}

src/main/java/com/graduationproject/studentinformationsystem/university/graduation/model/dto/request/StudentGraduationUnconfirmRequest.java

+1
Original file line numberDiff line numberDiff line change
@@ -18,5 +18,6 @@ public class StudentGraduationUnconfirmRequest implements Serializable {
1818
private String graduationId;
1919

2020
@Valid
21+
@NotNull
2122
private SisOperationInfoRequest operationInfoRequest;
2223
}

src/main/java/com/graduationproject/studentinformationsystem/university/lesson/student/registration/model/dto/request/StudentLessonRegistrationInfoRequest.java

+2
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
import com.graduationproject.studentinformationsystem.common.util.validation.id.StudentID;
44
import lombok.Getter;
55

6+
import javax.validation.constraints.NotEmpty;
67
import javax.validation.constraints.NotNull;
78
import java.io.Serial;
89
import java.io.Serializable;
@@ -19,5 +20,6 @@ public class StudentLessonRegistrationInfoRequest implements Serializable {
1920
private Long studentId;
2021

2122
@NotNull
23+
@NotEmpty
2224
private List<Long> lessonsIds;
2325
}

src/main/java/com/graduationproject/studentinformationsystem/university/note/model/dto/request/StudentLessonNoteSaveRequest.java

+1
Original file line numberDiff line numberDiff line change
@@ -32,5 +32,6 @@ public class StudentLessonNoteSaveRequest implements Serializable {
3232
private Long lessonId;
3333

3434
@Valid
35+
@NotNull
3536
private SisOperationInfoRequest operationInfoRequest;
3637
}

src/main/java/com/graduationproject/studentinformationsystem/university/note/model/dto/request/StudentsLessonFinalNotesConfirmRequest.java

+1
Original file line numberDiff line numberDiff line change
@@ -25,5 +25,6 @@ public class StudentsLessonFinalNotesConfirmRequest implements Serializable {
2525
private List<String> lessonNoteIds;
2626

2727
@Valid
28+
@NotNull
2829
private SisOperationInfoRequest operationInfoRequest;
2930
}

src/main/java/com/graduationproject/studentinformationsystem/university/note/model/dto/request/StudentsLessonFinalNotesUpdateRequest.java

+3
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77

88
import javax.validation.Valid;
99
import javax.validation.constraints.NotEmpty;
10+
import javax.validation.constraints.NotNull;
1011
import java.io.Serial;
1112
import java.io.Serializable;
1213
import java.util.Map;
@@ -19,9 +20,11 @@ public class StudentsLessonFinalNotesUpdateRequest implements Serializable {
1920
@Serial
2021
private static final long serialVersionUID = 5093920385984058988L;
2122

23+
@NotNull
2224
@NotEmpty
2325
private Map<String, Double> finalNoteIdsAndNotes;
2426

2527
@Valid
28+
@NotNull
2629
private SisOperationInfoRequest operationInfoRequest;
2730
}

src/main/java/com/graduationproject/studentinformationsystem/university/note/model/dto/request/StudentsLessonMidtermNotesConfirmRequest.java

+1
Original file line numberDiff line numberDiff line change
@@ -25,5 +25,6 @@ public class StudentsLessonMidtermNotesConfirmRequest implements Serializable {
2525
private List<String> lessonNoteIds;
2626

2727
@Valid
28+
@NotNull
2829
private SisOperationInfoRequest operationInfoRequest;
2930
}

src/main/java/com/graduationproject/studentinformationsystem/university/note/model/dto/request/StudentsLessonMidtermNotesUpdateRequest.java

+3
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77

88
import javax.validation.Valid;
99
import javax.validation.constraints.NotEmpty;
10+
import javax.validation.constraints.NotNull;
1011
import java.io.Serial;
1112
import java.io.Serializable;
1213
import java.util.Map;
@@ -19,9 +20,11 @@ public class StudentsLessonMidtermNotesUpdateRequest implements Serializable {
1920
@Serial
2021
private static final long serialVersionUID = 5142587290257640755L;
2122

23+
@NotNull
2224
@NotEmpty
2325
private Map<String, Double> midtermNoteIdsAndNotes;
2426

2527
@Valid
28+
@NotNull
2629
private SisOperationInfoRequest operationInfoRequest;
2730
}

src/main/java/com/graduationproject/studentinformationsystem/university/note/model/dto/request/StudentsLessonNoteStatusUpdateRequest.java

+1
Original file line numberDiff line numberDiff line change
@@ -31,5 +31,6 @@ public class StudentsLessonNoteStatusUpdateRequest implements Serializable {
3131
private StudentLessonNoteStatus status;
3232

3333
@Valid
34+
@NotNull
3435
private SisOperationInfoRequest operationInfoRequest;
3536
}

src/main/java/com/graduationproject/studentinformationsystem/university/note/model/dto/request/StudentsLessonResitNotesConfirmRequest.java

+1
Original file line numberDiff line numberDiff line change
@@ -25,5 +25,6 @@ public class StudentsLessonResitNotesConfirmRequest implements Serializable {
2525
private List<String> lessonNoteIds;
2626

2727
@Valid
28+
@NotNull
2829
private SisOperationInfoRequest operationInfoRequest;
2930
}

src/main/java/com/graduationproject/studentinformationsystem/university/note/model/dto/request/StudentsLessonResitNotesUpdateRequest.java

+3
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77

88
import javax.validation.Valid;
99
import javax.validation.constraints.NotEmpty;
10+
import javax.validation.constraints.NotNull;
1011
import java.io.Serial;
1112
import java.io.Serializable;
1213
import java.util.Map;
@@ -19,9 +20,11 @@ public class StudentsLessonResitNotesUpdateRequest implements Serializable {
1920
@Serial
2021
private static final long serialVersionUID = 4495180748614571012L;
2122

23+
@NotNull
2224
@NotEmpty
2325
private Map<String, Double> resitNoteIdsAndNotes;
2426

2527
@Valid
28+
@NotNull
2629
private SisOperationInfoRequest operationInfoRequest;
2730
}

0 commit comments

Comments
 (0)