Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Prophet struct to prevent invalid states #120

Open
coderabbitai bot opened this issue Oct 8, 2024 · 0 comments
Open

Refactor Prophet struct to prevent invalid states #120

coderabbitai bot opened this issue Oct 8, 2024 · 0 comments

Comments

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 8, 2024

The TODO comment in crates/augurs-prophet/src/prophet.rs suggests moving certain fields into a separate struct. Refactoring these fields can minimize the number of optional fields in the Prophet struct and reduce the risk of the struct being in an invalid state due to improper combinations of optional fields.

This issue was raised in PR #118.

PR URL: #118
Comment URL: #118 (comment)

Requested by @sd2k.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant