Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo uses static version of augurs #226

Open
sd2k opened this issue Jan 7, 2025 · 0 comments
Open

Demo uses static version of augurs #226

sd2k opened this issue Jan 7, 2025 · 0 comments

Comments

@sd2k
Copy link
Collaborator

sd2k commented Jan 7, 2025

The JS files used by the demo import augurs dependencies from the dist directory, but that directory just contains a static build of augurs rather than one built during CI. IIRC I did this to simplify the initial deployment of the demo to Cloudflare Pages, but it's not great because it's not being updated as new features/bugfixes are added.

However, I can't see Cloudflare Pages' build stage being able to build the augurs JS library from source since it requires a Rust toolchain and a bunch of other stuff (wasm-pack etc). What's the best way to make sure the demo is using the latest version?

From what I can see the options are:

  • use a JS framework and get Cloudflare Pages to build it using the latest published version - probably fine? but annoying to have to add a build stage
  • use some sort of hook & CI check to ensure the augurs build in demo/dist is up-to-date - more error prone and frustrating when I forget to update it...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant