Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error reporting on query timeout - context deadline exceeded #187

Open
gingerwizard opened this issue Sep 1, 2022 · 6 comments
Open
Assignees
Labels

Comments

@gingerwizard
Copy link
Collaborator

Currently, if the query deadline is exceeded (as controlled by QueryTimeout) in 2.0, the go driver returns a error querying the database: context deadline exceeded error. This isn't particularly clear and basically means the user needs to increase the query timeout (default 60s).

We should catch this specific error and wrap with something to indicate as such.

image

@gingerwizard gingerwizard changed the title Better error reporting on timeout Better error reporting on query timeout Sep 1, 2022
@gingerwizard gingerwizard changed the title Better error reporting on query timeout Better error reporting on query timeout - context deadline exceeded Sep 1, 2022
@gingerwizard
Copy link
Collaborator Author

note QueryTimeout is in 2.0 only - see #186

previous versions hardcoded at 30s.

@bossinc bossinc added the enhancement New feature or request label Sep 9, 2022
@gingerwizard
Copy link
Collaborator Author

This is a client issue. Ill wrap this error in the go-client and PR the plugin when we release the client.

@aangelisc
Copy link
Contributor

@gingerwizard are you able to create a PR for this? Was it fixed?

@alyssabull
Copy link
Contributor

Hey @gingerwizard - confirming if this issue was fixed and if so, is there a corresponding PR that we can link this issue to?

@jkaflik
Copy link
Collaborator

jkaflik commented Mar 12, 2024

@alyssabull no, this wasn't fixed yet. @SpencerTorres can you take a look?

@SpencerTorres
Copy link
Collaborator

@jkaflik yes, I can catch this error and add a clearer message 👍

@SpencerTorres SpencerTorres self-assigned this Mar 12, 2024
@SpencerTorres SpencerTorres added the good first issue Good for newcomers label Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Backlog
Development

No branches or pull requests

7 participants