Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logs volume: update DataSourceWithSupplementaryQueriesSupport implementation #715

Open
matyax opened this issue Feb 19, 2024 · 1 comment
Labels

Comments

@matyax
Copy link

matyax commented Feb 19, 2024

In grafana/grafana#80281 the interface was updated to deprecate getDataProvider in favor of getSupplementaryRequest, so data sources that need decoupling from Grafana Core don't depend on queryLogsVolume().

@matyax matyax added type/bug Something isn't working datasource/ClickHouse and removed type/bug Something isn't working labels Feb 19, 2024
@matyax
Copy link
Author

matyax commented Feb 19, 2024

Addressing the deprecation should be as simple as renaming getDataProvider to getSupplementaryRequest, and return the request instead of the Observable from queryLogsVolume(), but I see that you have a custom queryLogsVolume implementation that seems to also be doing aggregation and other modifications to the response: https://github.com/grafana/clickhouse-datasource/blob/main/src/data/logs.ts#L75C38-L83

Feel free to ping, I'll be happy to help.

@SpencerTorres SpencerTorres self-assigned this Feb 20, 2024
@aangelisc aangelisc added the enhancement New feature or request label Mar 20, 2024
@SpencerTorres SpencerTorres removed their assignment Mar 28, 2024
@SpencerTorres SpencerTorres added the good first issue Good for newcomers label Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Feature Requests
Development

No branches or pull requests

3 participants