Renderer: Fix regression on callback URL in plugin mode #103787
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AgnesToulet
requested review from
evictorero and
nmarrs
and removed request for
a team
evictorero
approved these changes
Apr 10, 2025
Contributor
evictorero
left a comment
evictorero
left a comment
There was a problem hiding this comment.
Tested with plugin (http and https) and remote render and works as expected.
I left some comments to improve legibility and discuss posible improvements.
Contributor
|
The backport to To backport manually, run these commands in your terminal: git fetch
git switch --create backport-103787-to-release-11.6.1 origin/release-11.6.1
git cherry-pick -x d7c554c25e614fd353436aa5db20a0fcb88bcb52Resolve the conflicts, then add the changes and run git add . && git cherry-pick --continueIf you have the GitHub CLI installed: git push --set-upstream origin backport-103787-to-release-11.6.1
PR_BODY=$(gh pr view 103787 --json body --template 'Backport d7c554c25e614fd353436aa5db20a0fcb88bcb52 from #103787{{ "\\n\\n---\\n\\n" }}{{ index . "body" }}')
echo "${PR_BODY}" | gh pr create --title '[release-11.6.1] Renderer: Fix regression on callback URL in plugin mode' --body-file - --label 'backport' --label '' --label 'type/bug' --label 'area/backend' --label 'add to changelog' --label 'area/image-rendering' --base release-11.6.1 --webOr, if you don't have the GitHub CLI installed (we recommend you install it!): git push --set-upstream origin backport-103787-to-release-11.6.1And open a pull request where the |
AgnesToulet
added a commit
that referenced
this pull request
Apr 11, 2025
* Renderer: Fix regression on callback URL in plugin mode * cleanup * refactor to not mutate cfg object * apply review feedback (cherry picked from commit d7c554c)
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
In this PR that introduces SSL support for the renderer, we missed that the
RendererCallbackURLwas actually always set insettings.goand this leads to issues for users not needing the SSL support (see grafana/grafana-image-renderer#617).Why do we need this feature?
We never intended the change above to be a breaking change, the image renderer should continue working for all users without any change on their side.
Who is this feature for?
Image renderer users (plugin mode)
Which issue(s) does this PR fix?:
Fixes grafana/grafana-image-renderer#617
Special notes for your reviewer:
Please check that: