Support builder pattern with imports (#203)

* Support builder pattern with imports
Weird case that we use at Grafana Labs. Lots of indirection with imports in the mix

* Fix errors

Author: julienduchesne

pkg/ast/processing/find_field.go

@@ -117,6 +117,24 @@ func (p *Processor) extractObjectRangesFromDesugaredObjs(desugaredObjs []*ast.De
 			case *ast.Apply:
 				// Add the target of the Apply to the list of field nodes to look for
 				// The target is a function and will be found by FindVarReference on the next loop
+				if idx, ok := fieldNode.Target.(*ast.Index); ok { // Builder pattern, run the function within the index
+					if importNode, ok := idx.Target.(*ast.Import); ok {
+						// If the index is a builder pattern, we need to run the function within the index
+						// We need to import the file first
+						objs := p.FindTopLevelObjectsInFile(importNode.File.Value, string(importNode.Loc().File.DiagnosticFileName))
+						for _, obj := range objs {
+							fieldString, ok := idx.Index.(*ast.LiteralString)
+							if !ok {
+								continue
+							}
+							if idxField := findObjectFieldsInObject(obj, fieldString.Value, false); len(idxField) > 0 {
+								fieldNodes = append(fieldNodes, idxField[0].Body)
+							}
+						}
+						i++
+						continue
+					}
+				}
 				fieldNodes = append(fieldNodes, fieldNode.Target)
 			case *ast.Var:
 				varReference, err := p.FindVarReference(fieldNode)

pkg/server/definition_test.go

@@ -929,17 +929,17 @@ var definitionTestCases = []definitionTestCase{
 	},
 	{
 		name:     "grafonnet: eval variable selection options",
-		filename: "./testdata/grafonnet/eval-variable-options.jsonnet",
+		filename: "./testdata/grafonnet-eval-variable-options.jsonnet",
 		position: protocol.Position{Line: 5, Character: 54},
 		results: []definitionResult{{
-			targetFilename: "testdata/grafonnet/vendor/github.com/grafana/grafonnet/gen/grafonnet-v10.0.0/custom/dashboard/variable.libsonnet",
+			targetFilename: "testdata/vendor/github.com/grafana/grafonnet/gen/grafonnet-v11.4.0/custom/dashboard/variable.libsonnet",
 			targetRange: protocol.Range{
-				Start: protocol.Position{Line: 101, Character: 12},
-				End:   protocol.Position{Line: 103, Character: 13},
+				Start: protocol.Position{Line: 122, Character: 12},
+				End:   protocol.Position{Line: 124, Character: 13},
 			},
 			targetSelectionRange: protocol.Range{
-				Start: protocol.Position{Line: 101, Character: 12},
-				End:   protocol.Position{Line: 101, Character: 21},
+				Start: protocol.Position{Line: 122, Character: 12},
+				End:   protocol.Position{Line: 122, Character: 21},
 			},
 		}},
 	},
@@ -988,6 +988,22 @@ var definitionTestCases = []definitionTestCase{
 			},
 		}},
 	},
+	{
+		name:     "goto ksonnet util",
+		filename: "testdata/use-ksonnet-util.jsonnet",
+		position: protocol.Position{Line: 11, Character: 30},
+		results: []definitionResult{{
+			targetFilename: "testdata/vendor/ksonnet-util/util.libsonnet",
+			targetRange: protocol.Range{
+				Start: protocol.Position{Line: 243, Character: 2},
+				End:   protocol.Position{Line: 251, Character: 5},
+			},
+			targetSelectionRange: protocol.Range{
+				Start: protocol.Position{Line: 243, Character: 2},
+				End:   protocol.Position{Line: 243, Character: 24},
+			},
+		}},
+	},
 }
 
 func TestDefinition(t *testing.T) {