Skip to content

[FEAT] Table/JSON: Unify selected line with logs panel #1435

@gtk-grafana

Description

@gtk-grafana

This is a good time to refactor it to panelState, taking it a step closer to a core visualization. The table was always the outlier and this creates a new outlier as well.

https://github.com/grafana/logs-drilldown/blob/main/src/Components/ServiceScene/LogsPanelScene.tsx#L423

But more like that, that they rely on the same implementation. The logs panel has a piece of code to sync that automatically, and Explore uses it as well. And by using it you have one less thing to implement when we move this to Grafana.

Meaning this: https://github.com/grafana/grafana/blob/e5d2f92384959afc61521416d9500a55c0971b15/packages/grafana-data/src/types/explore.ts#L76

And this https://github.com/grafana/grafana/blob/e5d2f92384959afc61521416d9500a55c0971b15/public/app/plugins/panel/logs/LogsPanel.tsx#L743

Even if the other views have their own version of LogsPanel.tsx, I think it'd be cool to follow the same conventions.

Originally posted by @matyax in #1431 (comment)

Tl;DR a log line selected in one viz should work in any viz if the user switches.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions