Commit ff5e32d
authored
fix(ci): run required checks when undrafting PRs (#428)
We just merged `release-please` support in
023c802. The user this runs as is the
default Actions bot user. One thing about this user in particular is
that it doesn't trigger workflows to run.
This means that its release PRs aren't actually mergeable, since we have
a couple of required checks which come from Actions runs.
Fortunately we don't have to switch to an app. We can use the fact that
the PRs are created in draft mode. To make a release, the process will
be
1. Make PR ready for review.
2. Add PR to merge queue.
Workflows can be triggered by the `ready_for_review` activity type on
the `pull_request` event. So they will be kicked off when a human does
step 1.1 parent 023c802 commit ff5e32d
2 files changed
+18
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
6 | 11 | | |
7 | 12 | | |
8 | 13 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
| 4 | + | |
5 | 5 | | |
6 | 6 | | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
7 | 13 | | |
8 | 14 | | |
| 15 | + | |
| 16 | + | |
9 | 17 | | |
10 | 18 | | |
11 | 19 | | |
12 | 20 | | |
13 | 21 | | |
14 | 22 | | |
| 23 | + | |
15 | 24 | | |
16 | 25 | | |
17 | 26 | | |
| |||
29 | 38 | | |
30 | 39 | | |
31 | 40 | | |
| 41 | + | |
| 42 | + | |
32 | 43 | | |
33 | 44 | | |
34 | 45 | | |
| |||
0 commit comments