Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove connectors at chunk boundaries within same component #65

Open
joehagmann opened this issue Apr 9, 2020 · 1 comment
Open

Remove connectors at chunk boundaries within same component #65

joehagmann opened this issue Apr 9, 2020 · 1 comment

Comments

@joehagmann
Copy link
Member

joehagmann commented Apr 9, 2020

If a single component is split into chunks, there are meaningless connectors at the chunk boundaries. Example covid-19:

image

corresponding bin2file:

image

the chunk boundary in the middle (pan coord 2260) is unnecessary

@josiahseaman
Copy link
Member

You are correct in thinking this doesn't look good to the user. For clarification, this is a symptom of a desired feature which was added here: graph-genome/component_segmentation#7 where large components get cut in half to fit in multiple files. We're going to need some way of detecting if a split is extraneous.

  • If the component.last_bin == chunk.last_bin and departures.length == 0 and next_component.arrivals.length == 0
    • then it's an unnecessary split on chunk boundary and should be rendered as continuous,
    • maybe even change the PangenomeSchematic.js representation to be one long component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants