fix

Author: yaacovCR

Diff for: src/execution/IncrementalGraph.ts

@@ -132,14 +132,8 @@ export class IncrementalGraph {
     return { newRootNodes, successfulExecutionGroups };
   }
 
-  removeDeferredFragment(
-    deferredFragmentRecord: DeferredFragmentRecord,
-  ): boolean {
-    if (!this._rootNodes.has(deferredFragmentRecord)) {
-      return false;
-    }
+  removeDeferredFragment(deferredFragmentRecord: DeferredFragmentRecord): void {
     this._rootNodes.delete(deferredFragmentRecord);
-    return true;
   }
 
   removeStream(streamRecord: StreamRecord): void {
@@ -219,7 +213,10 @@ export class IncrementalGraph {
     deferredFragmentRecord: DeferredFragmentRecord,
     initialResultChildren: Set<DeliveryGroup> | undefined,
   ): void {
-    if (this._rootNodes.has(deferredFragmentRecord)) {
+    if (
+      deferredFragmentRecord.failed ||
+      this._rootNodes.has(deferredFragmentRecord)
+    ) {
       return;
     }
     const parent = deferredFragmentRecord.parent;

Diff for: src/execution/IncrementalPublisher.ts

@@ -228,13 +228,13 @@ class IncrementalPublisher {
     if (isFailedExecutionGroup(completedExecutionGroup)) {
       for (const deferredFragmentRecord of completedExecutionGroup
         .pendingExecutionGroup.deferredFragmentRecords) {
-        const id = deferredFragmentRecord.id;
-        if (
-          !this._incrementalGraph.removeDeferredFragment(deferredFragmentRecord)
-        ) {
-          // This can occur if multiple deferred grouped field sets error for a fragment.
+        const failed = deferredFragmentRecord.failed;
+        if (failed) {
           continue;
         }
+        deferredFragmentRecord.failed = true;
+        const id = deferredFragmentRecord.id;
+        this._incrementalGraph.removeDeferredFragment(deferredFragmentRecord);
         invariant(id !== undefined);
         context.completed.push({
           id,

Diff for: src/execution/types.ts

@@ -224,6 +224,7 @@ export class DeferredFragmentRecord {
   pendingExecutionGroups: Set<PendingExecutionGroup>;
   successfulExecutionGroups: Set<SuccessfulExecutionGroup>;
   children: Set<DeliveryGroup>;
+  failed: true | undefined;
 
   constructor(
     path: Path | undefined,