Support setting app public-addr within Kubernetes app discovery #52459
+17
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
jimbishopp,
mmcallister,
ptgott,
r0mant,
xinding33 and
zmb3
zmb3
reviewed
Feb 25, 2025
lib/services/app_test.go
Outdated
| @@ -346,3 +346,24 @@ func TestInsecureSkipVerify(t *testing.T) { | |||
| require.Equal(t, tt.expected, result) | |||
| } | |||
| } | |||
|
|
|||
| func TestGetPublicAddrConfig(t *testing.T) { | |||
There was a problem hiding this comment.
This is testing a one line function that is just a map lookup, so it's unlikely to ever fail and probably won't ever catch a legitimate bug either.
What if we tested this via NewApplicationFromKubeService (see lib/srv/discovery/discovery_test.go) instead?
joaoubaldo
force-pushed
the
support_kubernetes_service_publicaddr
branch
from
d71fa40 to
b993218
Compare
|
LGTM. I'll open a buddy PR and chase down reviews for this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support setting an app public-addr within Kubernetes app discovery, just like other attributes.
Closes #52458
changelog: support public-addr annotation for Kubernetes services.