Skip to content

Conversation

@engigeer
Copy link
Contributor

I encountered an issue when homing required is enabled. It seems that Alarm 11 is never asserted following an e-stop with loss of position, but the machine remains in an Alarm state until the homing cycle is run. There is a message reported that homing is required, however these messages are not always visible (i.e., if I am operating the machine from a pendant / controller that only reports Alarm codes).

I'm thinking instead perhaps it would be better to mirror the handling case where homing is required but only some axes are homed.

core/system.c

Lines 466 to 477 in e272f77

if (retval == Status_OK && !sys.abort) {
state_set(STATE_IDLE); // Set to IDLE when complete.
st_go_idle(); // Set steppers to the settings idle state before returning.
grbl.report.feedback_message(Message_None);
// Execute startup scripts after successful homing.
if (sys.homing.mask && (sys.homing.mask & sys.homed.mask) == sys.homing.mask)
system_execute_startup(NULL);
else if(limits_homing_required()) { // Keep alarm state active if homing is required and not all axes homed.
sys.alarm = Alarm_HomingRequired;
state_set(STATE_ALARM);
}
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant