Skip to content

Internal speed signal is not updated in USBDevice. #125

@ronyrus

Description

@ronyrus

7d7960e introduced externally visible speed signal in USBDevice.
self.speed = Signal(2)
and it's updated from the reset sequencer:
self.speed .eq(reset_sequencer.current_speed),

however, there is also an internal speed signal:
speed = Signal(2, reset=USBSpeed.FULL)
This signal is passed into logic blocks, but is not updated at all.
It stays in its reset value.

IIUC, it should also be assigned to reset_sequencer.current_speed.
I wonder though, do we need two different signals in this case?
Probably better to just use the self.speed everywhere.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions