Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SMS] Thumbnail of contact not shown #1

Closed
duffydack opened this issue Jun 27, 2021 · 5 comments
Closed

[SMS] Thumbnail of contact not shown #1

duffydack opened this issue Jun 27, 2021 · 5 comments

Comments

@duffydack
Copy link

Great work fixing bboozzoo#58.
IDK, but would it be trivial to add thumbs for sms/messages?

@grimpy
Copy link
Owner

grimpy commented Jun 27, 2021

I don't think it's supported by kde-connect itself.
As far as I know sms/messages are appearing is normal notifications which don't have any thumbnail information attached

Seems notification image data is handled diffrently and might be a bit more complex to grab, I might have a look into this when I have a bit of time

@duffydack
Copy link
Author

That would be cool. Thanks

grimpy added a commit that referenced this issue Jun 27, 2021
See: #1

Signed-off-by: Jo De Boeck <[email protected]>
@grimpy
Copy link
Owner

grimpy commented Jun 27, 2021

@duffydack I found that there is some image data inside the notification which is now forwarded to your os notification.

Depending on your SMS application the value of the image can differ some apps just set the appicon...

Any feedback is welcome

@duffydack
Copy link
Author

duffydack commented Jun 27, 2021

That's improved the look a little for sure.

sway-2021-06-27_17-53-11

Using Google Messages. The only messaging app really I wanted to receive notifications for, (I filtered out everything else that I use on my desktop). I wonder where the contact icon is then. Hmm

@grimpy
Copy link
Owner

grimpy commented Jun 28, 2021

Going to close this issue as there is nothing left to be done from this side. If you would like to persue this i suggest you file and issue in the kde-connect app @ https://invent.kde.org/network/kdeconnect-android

@grimpy grimpy closed this as completed Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants