Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Output Format for Failing Tests in Maxitest #73

Closed
seuros opened this issue Nov 5, 2024 · 5 comments
Closed

Improve Output Format for Failing Tests in Maxitest #73

seuros opened this issue Nov 5, 2024 · 5 comments

Comments

@seuros
Copy link
Contributor

seuros commented Nov 5, 2024

When running Maxitest, the current output format for failing tests looks like this:

Focus on failing tests:
mtest test/controllers/interna_test.rb:41

It would be more helpful if the output included the full command to re-run the test, like so:

Focus on failing tests:
bin/rails test test/controllers/interna_test.rb:41

This would make it easier to quickly re-run failing tests without manually modifying the command.

@grosser
Copy link
Owner

grosser commented Nov 5, 2024

mtest test/controllers/interna_test.rb:41 is supposed to work too, but is broken because of minitest/minitest-rails#256
... I guess we could add a "use bin/rails" if "bin/rails" exists check to circumvent that

@seuros
Copy link
Contributor Author

seuros commented Nov 5, 2024

the binstub is not needed.

We could just do a bundle exec rails test .... if Rails is detected.

My concern is that you have that part of code vendored with do no modify warning

@grosser
Copy link
Owner

grosser commented Nov 5, 2024

should not be an issue, https://github.com/grosser/maxitest/blob/master/Rakefile#L16 this modifies the vendored code

@grosser
Copy link
Owner

grosser commented Nov 10, 2024

#74 -> 5.8.0

@grosser grosser closed this as completed Nov 10, 2024
@seuros
Copy link
Contributor Author

seuros commented Nov 10, 2024

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants