Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add source and target endpoint as label for all client/server grpc metrics #644

Open
rohsaini opened this issue Sep 18, 2023 · 2 comments
Open
Assignees

Comments

@rohsaini
Copy link
Contributor

All the metrics currently reported by providers/prometheus have labels as "grpc_type", "grpc_service" and "grpc_method". But since, these do not include source and target endpoint information, it is not possible to get metrics for a particular grpc_service per connection level. These are more like aggregated metrics at grpc_service level.

So requesting to include these two additional labels also.

Example:
grpc_server_msg_received_total{grpc_method="RegisterTimer",grpc_service="timergrpc.IpcService",grpc_type="unary"} 4

@johanbrandhorst
Copy link
Collaborator

I will leave this sort of decision to @bwplotka who is significantly more experience with metrics than I am.

@rohsaini
Copy link
Contributor Author

@bwplotka looking forward for your response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants