Skip to content

Commit ac7a60a

Browse files
committed
Improve comment in GrpcChannel for WinHttpHandler + OS validation (#2237)
1 parent 5256bc1 commit ac7a60a

File tree

1 file changed

+9
-1
lines changed

1 file changed

+9
-1
lines changed

src/Grpc.Net.Client/GrpcChannel.cs

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,15 @@ internal GrpcChannel(Uri address, GrpcChannelOptions channelOptions) : base(addr
185185
Log.AddressPathUnused(Logger, Address.OriginalString);
186186
}
187187

188-
// Validate the Windows version can support WinHttpHandler.
188+
// Grpc.Net.Client + .NET Framework + WinHttpHandler requires features in WinHTTP, shipped in Windows, to work correctly.
189+
// This scenario is supported in these versions of Windows or later:
190+
// -Windows Server 2022 has partial support.
191+
// -Unary and server streaming methods are supported.
192+
// -Client and bidi streaming methods aren't supported.
193+
// -Windows 11 has full support.
194+
//
195+
// GrpcChannel validates the Windows version is WinServer2022 or later. Win11 version number is greater than WinServer2022.
196+
// Note that this doesn't block using unsupported client and bidi streaming methods on WinServer2022.
189197
const int WinServer2022BuildVersion = 20348;
190198
if (HttpHandlerType == HttpHandlerType.WinHttpHandler &&
191199
OperatingSystem.IsWindows &&

0 commit comments

Comments
 (0)