Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New A72 changes for OpenTelemetry #8216

Open
purnesh42H opened this issue Apr 2, 2025 · 3 comments · May be fixed by #8226
Open

New A72 changes for OpenTelemetry #8216

purnesh42H opened this issue Apr 2, 2025 · 3 comments · May be fixed by #8226
Assignees
Labels
Area: Observability Includes Stats, Tracing, Channelz, Healthz, Binlog, Reflection, Admin, GCP Observability P2 Type: Internal Cleanup Refactors, etc

Comments

@purnesh42H
Copy link
Contributor

Several minor adjustments proposed in gRFC A72 (grpc/proposal#474) need to be implemented within the OpenTelemetry tracing code

@purnesh42H purnesh42H added Type: Internal Cleanup Refactors, etc Area: Observability Includes Stats, Tracing, Channelz, Healthz, Binlog, Reflection, Admin, GCP Observability P2 Status: Help Wanted labels Apr 2, 2025
@carsontham
Copy link

hi, I would like to help with this issue.

For the Inbound message received and Outbound message sent part, the current code already adheres to gRFC A72, using messages like Inbound compressed message and Outbound compressed message in trace.go

So it seems the remaining change is to update the span names in client_tracing.go and server_tracing.go.

Am I understanding this issue correctly?

@purnesh42H purnesh42H linked a pull request Apr 8, 2025 that will close this issue
@arjan-bal
Copy link
Contributor

arjan-bal commented Apr 9, 2025

Hi @carsontham, @vinothkumarr227 already has #8226 open to address this issue, so we'll let him handle it.

@vinothkumarr227
Copy link
Contributor

I'm looking into this. Please assign the issue to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Observability Includes Stats, Tracing, Channelz, Healthz, Binlog, Reflection, Admin, GCP Observability P2 Type: Internal Cleanup Refactors, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants