Skip to content

grpctest: minor improvements to the test logger implementation #7475

Open
@easwars

Description

@easwars

I'd like to suggest the following minor improvements to the test logger implementation:

  • Unexport the test logger implementation which is currently a package global here:
    var TLogger *tLogger
    • This would also require moving some methods on this type like ExpectError to be functions in the package
  • Make the above package global accessed atomically from tests. We have had test failures because of data races in the past because of this.
  • Change receiver names in method of the tLogger type to be tl instead of g

Metadata

Metadata

Assignees

No one assigned

    Labels

    Area: TestingIncludes tests and testing utilities that we have for unit and e2e tests within our repo.P2Type: Testing

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions