Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XdsClient does not cache onError for new watchers #11672

Open
ejona86 opened this issue Nov 6, 2024 · 0 comments
Open

XdsClient does not cache onError for new watchers #11672

ejona86 opened this issue Nov 6, 2024 · 0 comments
Labels
Milestone

Comments

@ejona86
Copy link
Member

ejona86 commented Nov 6, 2024

Consider the flow:

  1. Watcher X is added for resource A
  2. Resource A is received, but NACKed. Watcher X is called and told about the error
  3. Watcher Y is added for resource A. It doesn't receive a cached value (because one doesn't exist) and also isn't told about the error. It simply hangs

We already have code that checks for errors when adding a new watcher, but those are only for persistent errors where we can't even talk to the control plane (e.g., no control plane is defined for the authority). We probably need to save the error within onError().

@ejona86 ejona86 added the bug label Nov 6, 2024
@ejona86 ejona86 added this to the Next milestone Nov 6, 2024
@ejona86 ejona86 changed the title XdsClient does not cache onError for new subscribers XdsClient does not cache onError for new watchers Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant