Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize RobotContainer.java #12

Open
proan opened this issue Oct 25, 2024 · 2 comments
Open

Reorganize RobotContainer.java #12

proan opened this issue Oct 25, 2024 · 2 comments
Assignees

Comments

@proan
Copy link

proan commented Oct 25, 2024

RobotContainer.java [https://github.com/grt192/2024-Haunted-House/blob/main/2025%20Haunted%20House/src/main/java/frc/robot/RobotContainer.java] has a bunch of mechanisms now, but they are not well organized. Please clean up the file by collecting all related code together into one place. For example, all of the port definitions should be together. So public static final int justinPort = 2; should be next to private final int satvikPort = 0;. Ultimately it'd be great to assign constants for all the used ports.

@6kn4eakfr4s
Copy link
Member

Will commit updated version after testing tomorrow

@proan
Copy link
Author

proan commented Oct 25, 2024

And I know the PR process was a little tedious at this stage, but it's good to get practice with modern methods and to keep any rookies from blasting a big hole in everyone else's work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants