Skip to content

Commit

Permalink
fix: increase stream-load-timeout to 6 seconds
Browse files Browse the repository at this point in the history
@Asko-Dev reports that the `SteamLoadTimeoutError` seems to be thrown
"randomly" on iOS 17.5.1 ( see #298 ). That suggests that there is a race condition
with the timeout. Let's try to double the timeout (3s -> 6s) and see if
that helps.

Side changes:

* The ESLint setup is broken somehow and since linting is a pre-commit hook
  it blocks the committing process. Thus, removing the setup entirely for
  now. To be fixed later if deemed necessary.
* migrate legacy Nix setup to Nix flakes / direnv
  • Loading branch information
gruhn authored Jul 15, 2024
1 parent b5d08d9 commit a5dbaa2
Show file tree
Hide file tree
Showing 11 changed files with 5,061 additions and 4,321 deletions.
1 change: 1 addition & 0 deletions .envrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
use flake
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -228,3 +228,5 @@ $RECYCLE.BIN/
*.lnk

# End of https://www.toptal.com/developers/gitignore/api/node,linux,macos,windows,vue

.direnv
5 changes: 0 additions & 5 deletions .husky/pre-commit

This file was deleted.

2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Don't hesitate to open an issue if you have trouble.
### Setup Dev Environment

Canonically this package uses Node 18 and `pnpm` as a package manager.
If you are a [Nix](https://nixos.org/) user, there is a `shell.nix` file in the project root.
If you are a [Nix](https://nixos.org/) user, there is a `flake.nix` file in the project root.

Clone the repository and run

Expand Down
61 changes: 61 additions & 0 deletions flake.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

25 changes: 25 additions & 0 deletions flake.nix
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
{
description = "";

inputs = {
nixpkgs.url = "github:nixos/nixpkgs?ref=nixos-unstable";
flake-utils.url = "github:numtide/flake-utils";
};

outputs = { self, nixpkgs, flake-utils }:
flake-utils.lib.eachDefaultSystem (system:
let
pkgs = nixpkgs.legacyPackages.${system};
in
{
devShells.default = pkgs.mkShell {
buildInputs = with pkgs; [
nodejs_18
nodePackages.pnpm
nodePackages.typescript-language-server
vue-language-server
];
};
}
);
}
8 changes: 2 additions & 6 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,9 @@
"docs:dev": "vitepress dev docs",
"docs:build": "vitepress build docs",
"docs:preview": "vitepress preview docs",
"lint": "eslint **/*.{vue,js,ts} --fix --ignore-path .gitignore",
"format": "prettier **/*.{vue,ts,json,md} --write --ignore-path .gitignore --ignore-path docs/.gitignore",
"type-check": "vue-tsc --noEmit -p tsconfig.app.json --composite false",
"prepack": "pnpm run build",
"prepare": "husky install"
"prepack": "pnpm run build"
},
"main": "./dist/vue-qrcode-reader.js",
"module": "./dist/vue-qrcode-reader.js",
Expand Down Expand Up @@ -53,11 +51,9 @@
"eslint": "8.56.0",
"eslint-plugin-prettier": "5.1.0",
"eslint-plugin-vue": "9.19.2",
"husky": "8.0.3",
"lint-staged": "15.2.0",
"prettier": "3.1.1",
"semantic-release": "22.0.12",
"typescript": "5.3.3",
"typescript": "5.5.3",
"vite": "5.0.10",
"vite-plugin-dts": "3.6.4",
"vitepress": "1.0.0-rc.32",
Expand Down
Loading

0 comments on commit a5dbaa2

Please sign in to comment.