Skip to content

helmlint: support ci/default-values.yaml in addition to linter_values.yaml #130

Closed
@thiagowfx

Description

@thiagowfx

Describe the solution you'd like

Currently, the helmlint hook supports linter_values.yaml as an extra values file to pass to helm lint (docs).

The ask is to, in addition to this file, support ci/default-values.yaml as well.

Why? This would make this pre-commit hook compatible with the chart-testing tool (docs). Then it would be enough to maintain a single ci/default-values.yaml file for all linters.

Rationale: The chart-testing tool is quite popular. Supporting it would make it easier to adopt this pre-commit hook.

Describe alternatives you've considered

The file could be named differently, as long as it satisfies ci/*-values.yaml.

ci/default-values.yaml is a common pattern though: see search results in Sourcegraph.

Alternatively we could add a CLI flag to let the user configure which file to include, but this seems to be unnecessarily complex.

Additional context

I would be happy to send a PR for this FR if you agree with its premise.

It's just a matter of adding a new condition here.

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions