Add alert suppression checkbox to Restart Firefox warning

Author: cstigler

AppController.m

@@ -127,7 +127,7 @@ - (BOOL)showLongBlockWarningsIfNecessary {
         return retVal;
     }
 
-    NSString* LONG_BLOCK_SUPPRESSION_KEY = @"SuppressLongBlockWarnings";
+    NSString* LONG_BLOCK_SUPPRESSION_KEY = @"SuppressLongBlockWarning";
     int LONG_BLOCK_THRESHOLD_MINS = 2880; // 2 days
     int FIRST_TIME_LONG_BLOCK_THRESHOLD_MINS = 480; // 8 hours
 

SCConstants.m

@@ -62,6 +62,7 @@ @implementation SCConstants
             @"EnableErrorReporting": @([SCMiscUtilities systemThirdPartyCrashReportingEnabled]),
             @"ErrorReportingPromptDismissed": @NO,
             @"SuppressLongBlockWarning": @NO,
+            @"SuppressRestartFirefoxWarning": @NO,
             @"FirstBlockStarted": @NO,
 
             @"V4MigrationComplete": @NO

SCUIUtilities.m

@@ -117,14 +117,27 @@ + (BOOL)promptBrowserRestartIfNecessary {
         });
         return retVal;
     }
-    
+
+    NSString* RESTART_FF_SUPPRESSION_KEY = @"SuppressRestartFirefoxWarning";
+    NSUserDefaults* defaults = [NSUserDefaults standardUserDefaults];
+
+    // if they don't want the warnings, they don't get the warnings
+    if ([defaults boolForKey: RESTART_FF_SUPPRESSION_KEY]) {
+        return NO;
+    }
+
     NSAlert* alert = [[NSAlert alloc] init];
     [alert setMessageText: NSLocalizedString(@"Restart Firefox", "FireFox browser restart prompt")];
     [alert setInformativeText:NSLocalizedString(@"SelfControl's block may not work properly in Firefox until you restart the browser. Do you want to quit Firefox now?", @"Message explaining Firefox restart requirement")];
     [alert addButtonWithTitle: NSLocalizedString(@"Quit Firefox", @"Button to quit Firefox")];
     [alert addButtonWithTitle: NSLocalizedString(@"Continue Without Restart", "Button to decline restarting Firefox")];
-    
+    alert.showsSuppressionButton = YES;
+
     NSModalResponse modalResponse = [alert runModal];
+    if (alert.suppressionButton.state == NSControlStateValueOn) {
+        // no more warnings, they say
+        [defaults setBool: YES forKey: RESTART_FF_SUPPRESSION_KEY];
+    }
     if (modalResponse == NSAlertFirstButtonReturn) {
         for (NSRunningApplication* ff in runningFF) {
             [ff terminate];