Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension to other POS Taxonomies Beyond Nouns #19

Open
ejshieh opened this issue Feb 16, 2018 · 2 comments
Open

Extension to other POS Taxonomies Beyond Nouns #19

ejshieh opened this issue Feb 16, 2018 · 2 comments

Comments

@ejshieh
Copy link

ejshieh commented Feb 16, 2018

First off, thank you for building sematch! This package has been incredibly valuable for me.

Suggestion / question - is there any reason why WordNetSimilarity is restricted to only nouns at the moment? I noticed that synsets seem to be restricted to nouns only, but WordNet includes verb taxonomies also.

Relevant code:

nltk.corpus.wordnet.synsets doesn't require the POS argument to be passed in (it defaults to nltk.corpus.wordnet.POS_LIST, so I think a potentially nice extension would be to remove the restriction on measuring similarity between nouns only

@ejshieh
Copy link
Author

ejshieh commented Feb 16, 2018

An example of what this looks like right now:

>>> from sematch.semantic.similarity import WordNetSimilarity
>>> wns = WordNetSimilarity()
>>> wns.word_similarity('sit', 'lounge')
0

@balkian
Copy link
Member

balkian commented Oct 26, 2020

I'm not the original author, but I agree with you. I believe there is no technical reason for this, there just wasn't a use case that needed similarity between other POS.

The change is fairly straightforward, I will get back to it once we achieve Py3 compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants