Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relaying doesn't work when TCPOnly is enabled #438

Open
DDoSolitary opened this issue Jul 7, 2023 · 0 comments
Open

Relaying doesn't work when TCPOnly is enabled #438

DDoSolitary opened this issue Jul 7, 2023 · 0 comments
Labels
bug Issues in which the users gave a clear indication to the causes of the unexpected behaviour needs_investigation Unexpected behaviours with uncertain causes - needs more investigation

Comments

@DDoSolitary
Copy link

Assume the following topology:
A <--> B <--> C
(A and C are behind firewalls and can only establish direct TCP connection with B)

If I set TCPOnly = yes for node C, B will drop packets sent from A to C, while all other situations work properly (B to C, C to B, and even C to A)
If I leave TCPOnly = no, even though only TCP connections are available (as UDP packets will be dropped by firewalls), everything works as expected.

After some digging, I found that TCPOnly enabled nodes will never have the validkey status flag set, and packets indirectly targeting C are dropped by B from here: 2c9126a
If I revert the commit everything works again, but I'm not sure if it's the correct way to fix the problem, or there's something wrong elsewhere resulting in validkey unset.

@DDoSolitary DDoSolitary changed the title Realying doesn't work when TCPOnly is enabled Relaying doesn't work when TCPOnly is enabled Jul 7, 2023
@gsliepen gsliepen added needs_investigation Unexpected behaviours with uncertain causes - needs more investigation bug Issues in which the users gave a clear indication to the causes of the unexpected behaviour labels Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues in which the users gave a clear indication to the causes of the unexpected behaviour needs_investigation Unexpected behaviours with uncertain causes - needs more investigation
Projects
None yet
Development

No branches or pull requests

2 participants