[IDP-1766] Improve configuration#10
Merged
Tommy Josépovic (tjosepo) merged 11 commits intomainfrom Jul 9, 2024
Merged
Conversation
39be001 to
695e648
Compare
Member
Author
|
Paths have been fixed (Until proven otherwise 😅) During the |
heqianwang
reviewed
Jul 8, 2024
Anthony Simmon (asimmon)
approved these changes
Jul 9, 2024
heqianwang
approved these changes
Jul 9, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
The whole design of this feature is heavily inspired by Vite. See InlineConfig, resolveconfig() and CLI
Improves CLI configuration with commander:
Add support for config file with c12:
User configuration is now validated with zod (feel free to bikeshed on the format of the message):
$ pnpm exec create-schemas -o out.ts Invalid configuration: - input: Required Use --help to see available options.Breaking changes
The
openapi-typescriptcommand line arguments are no longer supported on the CLI. Instead, they need to be declared in the configuration file in theopenApiTsOptionsproperty.Additional checks
As mentionned, still waiting for #8 and #9 to get merged. Once they are merged, I will update this PR to include a changeset and tests.