Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IDP-1623] Fix release workflow #11

Merged
merged 5 commits into from
Jul 4, 2024
Merged

Conversation

tjosepo
Copy link
Member

@tjosepo tjosepo commented Jul 4, 2024

Description of changes

Release workflow broke after merging #8. Turns out that the order in which pnpm and node actions are run matters.

I added a "setup" action that can be reused in both CI and Publish workflows, so that they cannot drift anymore.

I am currently learning Github Action as I am doing this PR. This seems to work fine, but let me know if there are better ways to do this. :)

@tjosepo tjosepo requested a review from a team as a code owner July 4, 2024 00:47
@tjosepo tjosepo changed the title [IDP-1623] Fix release branch [IDP-1623] Fix release workflow Jul 4, 2024
.github/workflows/ci.yml Show resolved Hide resolved
@tjosepo tjosepo merged commit 3aaf7db into main Jul 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants