Skip to content

Commit 5688429

Browse files
author
Jelle Fresen
committedMar 24, 2020
Extend code-review etiquette
Bug: N/A Test: None Change-Id: I0aee7e97515610e38a0b8bba46c285adc0a13708
1 parent 9f4b917 commit 5688429

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed
 

‎code-review.md

+1
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
comments or reassigning to a better reviewer
2929
* Within 16 working hours, review changes if you are not assignee on. It is appropriate to
3030
remove yourself from the review if you are not expecting to review the given change.
31+
* If already CR+2'ed by someone else, it is not required to give CR+2 again
3132
* Prioritize reviews from other timezones (_e.g. MTV reviewers should review LON changes before 11am if possible to expedite the change_)
3233
* Pay attention to the phrasing of your review comments
3334
* Avoid using subjective statements such as “I don’t like it” or “This is bad”, use actionable ones like “Added APIs could cause performance issues, consider using Foo instead” or “Use more meaningful variable names”

0 commit comments

Comments
 (0)