You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardexpand all lines: code-review.md
+1
Original file line number
Diff line number
Diff line change
@@ -28,6 +28,7 @@
28
28
comments or reassigning to a better reviewer
29
29
* Within 16 working hours, review changes if you are not assignee on. It is appropriate to
30
30
remove yourself from the review if you are not expecting to review the given change.
31
+
* If already CR+2'ed by someone else, it is not required to give CR+2 again
31
32
* Prioritize reviews from other timezones (_e.g. MTV reviewers should review LON changes before 11am if possible to expedite the change_)
32
33
* Pay attention to the phrasing of your review comments
33
34
* Avoid using subjective statements such as “I don’t like it” or “This is bad”, use actionable ones like “Added APIs could cause performance issues, consider using Foo instead” or “Use more meaningful variable names”
0 commit comments