Skip to content

Commit 7905a13

Browse files
tiembotiembo
committed
Add lint check to ban use of @hide annotation
Also update lint baseline files Bug: 272083740 Test: presubmit and BanHideAnnotationTest Merged-In: Iaa212192c3071141028fcaf7662f6e112c7c0f23 Change-Id: Iaa212192c3071141028fcaf7662f6e112c7c0f23
1 parent ad23424 commit 7905a13

File tree

61 files changed

+10753
-23
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

61 files changed

+10753
-23
lines changed

‎appactions/interaction/interaction-capabilities-core/lint-baseline.xml

+130
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,130 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<issues format="6" by="lint 8.1.0-alpha07" type="baseline" client="gradle" dependencies="false" name="AGP (8.0.0-beta03)" variant="all" version="8.1.0-alpha07">
3+
4+
<issue
5+
id="BanHideAnnotation"
6+
message="@hide is not allowed in Javadoc"
7+
errorLine1=" fun getAppAction(): AppAction"
8+
errorLine2=" ~~~~~~~~~~~~">
9+
<location
10+
file="src/main/java/androidx/appactions/interaction/capabilities/core/ActionCapability.kt"/>
11+
</issue>
12+
13+
<issue
14+
id="BanHideAnnotation"
15+
message="@hide is not allowed in Javadoc"
16+
errorLine1=" fun createSession(hostProperties: HostProperties): ActionCapabilitySession"
17+
errorLine2=" ~~~~~~~~~~~~~">
18+
<location
19+
file="src/main/java/androidx/appactions/interaction/capabilities/core/ActionCapability.kt"/>
20+
</issue>
21+
22+
<issue
23+
id="BanHideAnnotation"
24+
message="@hide is not allowed in Javadoc"
25+
errorLine1="interface ActionCapabilitySession {"
26+
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~">
27+
<location
28+
file="src/main/java/androidx/appactions/interaction/capabilities/core/impl/ActionCapabilitySession.kt"/>
29+
</issue>
30+
31+
<issue
32+
id="BanHideAnnotation"
33+
message="@hide is not allowed in Javadoc"
34+
errorLine1="interface AppEntityListListener&lt;T> : ValueListener&lt;List&lt;T>> {"
35+
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~">
36+
<location
37+
file="src/main/java/androidx/appactions/interaction/capabilities/core/task/AppEntityListListener.kt"/>
38+
</issue>
39+
40+
<issue
41+
id="BanHideAnnotation"
42+
message="@hide is not allowed in Javadoc"
43+
errorLine1="interface AppEntityListener&lt;T> : ValueListener&lt;T> {"
44+
errorLine2=" ~~~~~~~~~~~~~~~~~">
45+
<location
46+
file="src/main/java/androidx/appactions/interaction/capabilities/core/task/AppEntityListener.kt"/>
47+
</issue>
48+
49+
<issue
50+
id="BanHideAnnotation"
51+
message="@hide is not allowed in Javadoc"
52+
errorLine1="annotation class CapabilityFactory(val name: String)"
53+
errorLine2=" ~~~~~~~~~~~~~~~~~">
54+
<location
55+
file="src/main/java/androidx/appactions/interaction/capabilities/core/CapabilityFactory.kt"/>
56+
</issue>
57+
58+
<issue
59+
id="BanHideAnnotation"
60+
message="@hide is not allowed in Javadoc"
61+
errorLine1=" fun lookupInternal(request: GroundingRequest): GroundingResponse {"
62+
errorLine2=" ~~~~~~~~~~~~~~">
63+
<location
64+
file="src/main/java/androidx/appactions/interaction/capabilities/core/entity/EntityProvider.kt"/>
65+
</issue>
66+
67+
<issue
68+
id="BanHideAnnotation"
69+
message="@hide is not allowed in Javadoc"
70+
errorLine1="interface InventoryListListener&lt;T> : ValueListener&lt;List&lt;T>> {"
71+
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~">
72+
<location
73+
file="src/main/java/androidx/appactions/interaction/capabilities/core/task/InventoryListListener.kt"/>
74+
</issue>
75+
76+
<issue
77+
id="BanHideAnnotation"
78+
message="@hide is not allowed in Javadoc"
79+
errorLine1="interface InventoryListener&lt;T> : ValueListener&lt;T> {"
80+
errorLine2=" ~~~~~~~~~~~~~~~~~">
81+
<location
82+
file="src/main/java/androidx/appactions/interaction/capabilities/core/task/InventoryListener.kt"/>
83+
</issue>
84+
85+
<issue
86+
id="BanHideAnnotation"
87+
message="@hide is not allowed in Javadoc"
88+
errorLine1="data class LibInfo(val context: Context) {"
89+
errorLine2=" ~~~~~~~">
90+
<location
91+
file="src/main/java/androidx/appactions/interaction/capabilities/core/LibInfo.kt"/>
92+
</issue>
93+
94+
<issue
95+
id="BanHideAnnotation"
96+
message="@hide is not allowed in Javadoc"
97+
errorLine1="fun &lt;T> convertToListenableFuture("
98+
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~">
99+
<location
100+
file="src/main/java/androidx/appactions/interaction/capabilities/core/impl/concurrent/ListenableFutureHelper.kt"/>
101+
</issue>
102+
103+
<issue
104+
id="BanHideAnnotation"
105+
message="@hide is not allowed in Javadoc"
106+
errorLine1="fun interface SessionBridge&lt;"
107+
errorLine2=" ~~~~~~~~~~~~~">
108+
<location
109+
file="src/main/java/androidx/appactions/interaction/capabilities/core/task/impl/SessionBridge.kt"/>
110+
</issue>
111+
112+
<issue
113+
id="BanHideAnnotation"
114+
message="@hide is not allowed in Javadoc"
115+
errorLine1="internal class SingleTurnCapabilityImpl&lt;"
116+
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~">
117+
<location
118+
file="src/main/java/androidx/appactions/interaction/capabilities/core/impl/SingleTurnCapabilityImpl.kt"/>
119+
</issue>
120+
121+
<issue
122+
id="BanHideAnnotation"
123+
message="@hide is not allowed in Javadoc"
124+
errorLine1="internal class SingleTurnCapabilitySession&lt;"
125+
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~">
126+
<location
127+
file="src/main/java/androidx/appactions/interaction/capabilities/core/impl/SingleTurnCapabilitySession.kt"/>
128+
</issue>
129+
130+
</issues>

‎appactions/interaction/interaction-service/lint-baseline.xml

+45
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,51 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<issues format="6" by="lint 8.1.0-alpha07" type="baseline" client="gradle" dependencies="false" name="AGP (8.0.0-beta03)" variant="all" version="8.1.0-alpha07">
33

4+
<issue
5+
id="BanHideAnnotation"
6+
message="@hide is not allowed in Javadoc"
7+
errorLine1="object AppInteractionServiceFactory {"
8+
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
9+
<location
10+
file="src/main/java/androidx/appactions/interaction/service/AppInteractionServiceFactory.kt"/>
11+
</issue>
12+
13+
<issue
14+
id="BanHideAnnotation"
15+
message="@hide is not allowed in Javadoc"
16+
errorLine1="data class RemoteViewsInternal("
17+
errorLine2=" ~~~~~~~~~~~~~~~~~~~">
18+
<location
19+
file="src/main/java/androidx/appactions/interaction/service/RemoteViewsInternal.kt"/>
20+
</issue>
21+
22+
<issue
23+
id="BanHideAnnotation"
24+
message="@hide is not allowed in Javadoc"
25+
errorLine1="data class TileLayoutInternal("
26+
errorLine2=" ~~~~~~~~~~~~~~~~~~">
27+
<location
28+
file="src/main/java/androidx/appactions/interaction/service/TileLayoutInternal.kt"/>
29+
</issue>
30+
31+
<issue
32+
id="BanHideAnnotation"
33+
message="@hide is not allowed in Javadoc"
34+
errorLine1=" val remoteViewsInternal: RemoteViewsInternal?"
35+
errorLine2=" ~~~~~~~~~~~~~~~~~~~">
36+
<location
37+
file="src/main/java/androidx/appactions/interaction/service/UiResponse.kt"/>
38+
</issue>
39+
40+
<issue
41+
id="BanHideAnnotation"
42+
message="@hide is not allowed in Javadoc"
43+
errorLine1=" val tileLayoutInternal: TileLayoutInternal?"
44+
errorLine2=" ~~~~~~~~~~~~~~~~~~">
45+
<location
46+
file="src/main/java/androidx/appactions/interaction/service/UiResponse.kt"/>
47+
</issue>
48+
449
<issue
550
id="UnsafeOptInUsageError"
651
message="This declaration is opt-in and its usage should be marked with `@androidx.wear.tiles.TilesExperimental` or `@OptIn(markerClass = androidx.wear.tiles.TilesExperimental.class)`"

‎appsearch/appsearch-builtin-types/lint-baseline.xml

+76
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,76 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<issues format="6" by="lint 8.1.0-alpha07" type="baseline" client="gradle" dependencies="false" name="AGP (8.0.0-beta03)" variant="all" version="8.1.0-alpha07">
3+
4+
<issue
5+
id="BanHideAnnotation"
6+
message="@hide is not allowed in Javadoc"
7+
errorLine1=" public @interface Status {}"
8+
errorLine2=" ~~~~~~">
9+
<location
10+
file="src/main/java/androidx/appsearch/builtintypes/AlarmInstance.java"/>
11+
</issue>
12+
13+
<issue
14+
id="BanHideAnnotation"
15+
message="@hide is not allowed in Javadoc"
16+
errorLine1="public class BootCountUtil {"
17+
errorLine2=" ~~~~~~~~~~~~~">
18+
<location
19+
file="src/main/java/androidx/appsearch/utils/BootCountUtil.java"/>
20+
</issue>
21+
22+
<issue
23+
id="BanHideAnnotation"
24+
message="@hide is not allowed in Javadoc"
25+
errorLine1="public final class DateTimeFormatValidator {"
26+
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~">
27+
<location
28+
file="src/main/java/androidx/appsearch/utils/DateTimeFormatValidator.java"/>
29+
</issue>
30+
31+
<issue
32+
id="BanHideAnnotation"
33+
message="@hide is not allowed in Javadoc"
34+
errorLine1=" public @interface NameType {"
35+
errorLine2=" ~~~~~~~~">
36+
<location
37+
file="src/main/java/androidx/appsearch/builtintypes/Person.java"/>
38+
</issue>
39+
40+
<issue
41+
id="BanHideAnnotation"
42+
message="@hide is not allowed in Javadoc"
43+
errorLine1=" public static final String DEFAULT_DATABASE = &quot;__shortcut_adapter_db__&quot;;"
44+
errorLine2=" ~~~~~~~~~~~~~~~~">
45+
<location
46+
file="src/main/java/androidx/appsearch/app/ShortcutAdapter.java"/>
47+
</issue>
48+
49+
<issue
50+
id="BanHideAnnotation"
51+
message="@hide is not allowed in Javadoc"
52+
errorLine1=" public static GenericDocument extractDocument(@NonNull final ShortcutInfoCompat shortcut) {"
53+
errorLine2=" ~~~~~~~~~~~~~~~">
54+
<location
55+
file="src/main/java/androidx/appsearch/app/ShortcutAdapter.java"/>
56+
</issue>
57+
58+
<issue
59+
id="BanHideAnnotation"
60+
message="@hide is not allowed in Javadoc"
61+
errorLine1=" public @interface Status {}"
62+
errorLine2=" ~~~~~~">
63+
<location
64+
file="src/main/java/androidx/appsearch/builtintypes/Stopwatch.java"/>
65+
</issue>
66+
67+
<issue
68+
id="BanHideAnnotation"
69+
message="@hide is not allowed in Javadoc"
70+
errorLine1=" public @interface Status {}"
71+
errorLine2=" ~~~~~~">
72+
<location
73+
file="src/main/java/androidx/appsearch/builtintypes/Timer.java"/>
74+
</issue>
75+
76+
</issues>

‎appsearch/appsearch-debug-view/lint-baseline.xml

+112
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,112 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<issues format="6" by="lint 8.1.0-alpha07" type="baseline" client="gradle" dependencies="false" name="AGP (8.0.0-beta03)" variant="all" version="8.1.0-alpha07">
3+
4+
<issue
5+
id="BanHideAnnotation"
6+
message="@hide is not allowed in Javadoc"
7+
errorLine1="public class AppSearchDebugActivity extends FragmentActivity {"
8+
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~">
9+
<location
10+
file="src/main/java/androidx/appsearch/debugview/view/AppSearchDebugActivity.java"/>
11+
</issue>
12+
13+
<issue
14+
id="BanHideAnnotation"
15+
message="@hide is not allowed in Javadoc"
16+
errorLine1="public class DebugAppSearchManager implements Closeable {"
17+
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~">
18+
<location
19+
file="src/main/java/androidx/appsearch/debugview/DebugAppSearchManager.java"/>
20+
</issue>
21+
22+
<issue
23+
id="BanHideAnnotation"
24+
message="@hide is not allowed in Javadoc"
25+
errorLine1="public class DocumentFragment extends Fragment {"
26+
errorLine2=" ~~~~~~~~~~~~~~~~">
27+
<location
28+
file="src/main/java/androidx/appsearch/debugview/view/DocumentFragment.java"/>
29+
</issue>
30+
31+
<issue
32+
id="BanHideAnnotation"
33+
message="@hide is not allowed in Javadoc"
34+
errorLine1="public class DocumentListFragment extends Fragment {"
35+
errorLine2=" ~~~~~~~~~~~~~~~~~~~~">
36+
<location
37+
file="src/main/java/androidx/appsearch/debugview/view/DocumentListFragment.java"/>
38+
</issue>
39+
40+
<issue
41+
id="BanHideAnnotation"
42+
message="@hide is not allowed in Javadoc"
43+
errorLine1="public class DocumentListItemAdapter extends"
44+
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~">
45+
<location
46+
file="src/main/java/androidx/appsearch/debugview/view/DocumentListItemAdapter.java"/>
47+
</issue>
48+
49+
<issue
50+
id="BanHideAnnotation"
51+
message="@hide is not allowed in Javadoc"
52+
errorLine1="public class DocumentListModel extends ViewModel {"
53+
errorLine2=" ~~~~~~~~~~~~~~~~~">
54+
<location
55+
file="src/main/java/androidx/appsearch/debugview/model/DocumentListModel.java"/>
56+
</issue>
57+
58+
<issue
59+
id="BanHideAnnotation"
60+
message="@hide is not allowed in Javadoc"
61+
errorLine1="public class DocumentModel extends ViewModel {"
62+
errorLine2=" ~~~~~~~~~~~~~">
63+
<location
64+
file="src/main/java/androidx/appsearch/debugview/model/DocumentModel.java"/>
65+
</issue>
66+
67+
<issue
68+
id="BanHideAnnotation"
69+
message="@hide is not allowed in Javadoc"
70+
errorLine1="public class MenuFragment extends Fragment {"
71+
errorLine2=" ~~~~~~~~~~~~">
72+
<location
73+
file="src/main/java/androidx/appsearch/debugview/view/MenuFragment.java"/>
74+
</issue>
75+
76+
<issue
77+
id="BanHideAnnotation"
78+
message="@hide is not allowed in Javadoc"
79+
errorLine1="public class SchemaTypeListFragment extends Fragment {"
80+
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~">
81+
<location
82+
file="src/main/java/androidx/appsearch/debugview/view/SchemaTypeListFragment.java"/>
83+
</issue>
84+
85+
<issue
86+
id="BanHideAnnotation"
87+
message="@hide is not allowed in Javadoc"
88+
errorLine1="public class SchemaTypeListItemAdapter extends"
89+
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~">
90+
<location
91+
file="src/main/java/androidx/appsearch/debugview/view/SchemaTypeListItemAdapter.java"/>
92+
</issue>
93+
94+
<issue
95+
id="BanHideAnnotation"
96+
message="@hide is not allowed in Javadoc"
97+
errorLine1="public class SchemaTypeListModel extends ViewModel {"
98+
errorLine2=" ~~~~~~~~~~~~~~~~~~~">
99+
<location
100+
file="src/main/java/androidx/appsearch/debugview/model/SchemaTypeListModel.java"/>
101+
</issue>
102+
103+
<issue
104+
id="BanHideAnnotation"
105+
message="@hide is not allowed in Javadoc"
106+
errorLine1="public abstract class ScrollListener extends RecyclerView.OnScrollListener {"
107+
errorLine2=" ~~~~~~~~~~~~~~">
108+
<location
109+
file="src/main/java/androidx/appsearch/debugview/view/ScrollListener.java"/>
110+
</issue>
111+
112+
</issues>

0 commit comments

Comments
 (0)