Add lint check to ban usage of non-default @VisibleForTesting params

Suppresses existing API lint issues in modified libraries so that we can
pass updateApi.

Removes @VisibleForTesting annotations gated by @RestrictTo, which don't
serve a practical purpose beyond documentation.

Baselines rapidly-changing credential library so that we can actually get
this landed.

Bug: 277361353
Test: BanVisibleForTestingParamsTest
Test: ./gradlew lintDebug
Merged-In: Iece4b035e3796ff3f0516193bc1dbcde8aa1307c
Change-Id: Iece4b035e3796ff3f0516193bc1dbcde8aa1307c

Author: alanv

activity/activity/src/main/java/androidx/activity/EdgeToEdge.kt

@@ -34,13 +34,13 @@ import androidx.core.view.WindowInsetsControllerCompat
 
 // The light scrim color used in the platform API 29+
 // https://cs.android.com/android/platform/superproject/+/master:frameworks/base/core/java/com/android/internal/policy/DecorView.java;drc=6ef0f022c333385dba2c294e35b8de544455bf19;l=142
-@VisibleForTesting(otherwise = VisibleForTesting.PRIVATE)
+@VisibleForTesting
 internal val DefaultLightScrim = Color.argb(0xe6, 0xFF, 0xFF, 0xFF)
 
 // The dark scrim color used in the platform.
 // https://cs.android.com/android/platform/superproject/+/master:frameworks/base/core/res/res/color/system_bar_background_semi_transparent.xml
 // https://cs.android.com/android/platform/superproject/+/master:frameworks/base/core/res/remote_color_resources_res/values/colors.xml;l=67
-@VisibleForTesting(otherwise = VisibleForTesting.PRIVATE)
+@VisibleForTesting
 internal val DefaultDarkScrim = Color.argb(0x80, 0x1b, 0x1b, 0x1b)
 
 private var Impl: EdgeToEdgeImpl? = null

benchmark/benchmark-common/src/main/java/androidx/benchmark/BenchmarkState.kt

@@ -146,7 +146,7 @@ public class BenchmarkState internal constructor(
      * This value is overridden by the end of the warmup stage. The default value defines
      * behavior for modes that bypass warmup (dryRun and startup).
      */
-    @VisibleForTesting(otherwise = VisibleForTesting.PRIVATE)
+    @VisibleForTesting
     internal var iterationsPerRepeat = 1
 
     private var state = NOT_STARTED // Current benchmark state.

buildSrc/private/src/main/kotlin/androidx/build/LintConfiguration.kt

@@ -231,6 +231,9 @@ fun Project.configureLint(lint: Lint, extension: AndroidXExtension, isLibrary: B
         // Disable until ag/19949626 goes in (b/261918265)
         disable.add("MissingQuantity")
 
+        // Disable new lint check so that we can land incrementally.
+        disable.add("VisibleForTests")
+
         // Provide stricter enforcement for project types intended to run on a device.
         if (extension.type.compilationTarget == CompilationTarget.DEVICE) {
             fatal.add("Assert")

camera/camera-camera2-pipe-integration/src/main/java/androidx/camera/camera2/pipe/integration/interop/Camera2CameraControl.kt

@@ -49,7 +49,7 @@ class Camera2CameraControl
 private constructor(
     private val compat: Camera2CameraControlCompat,
     private val threads: UseCaseThreads,
-    @VisibleForTesting(otherwise = VisibleForTesting.PRIVATE) internal val requestListener:
+    @VisibleForTesting internal val requestListener:
     ComboRequestListener,
 ) : UseCaseCameraControl {
 

camera/camera-camera2/lint-baseline.xml

@@ -136,4 +136,13 @@
             file="src/main/java/androidx/camera/camera2/internal/ImageCaptureOptionUnpacker.java"/>
     </issue>
 
+    <issue
+        id="VisibleForTests"
+        message="This method should only be accessed from tests or within private scope"
+        errorLine1="                    characteristics = CameraCharacteristicsCompat.toCameraCharacteristicsCompat("
+        errorLine2="                                                                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
+        <location
+            file="src/main/java/androidx/camera/camera2/internal/compat/CameraManagerCompat.java"/>
+    </issue>
+
 </issues>

camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/compat/CameraCharacteristicsCompat.java

@@ -62,7 +62,7 @@ private CameraCharacteristicsCompat(@NonNull CameraCharacteristics cameraCharact
      * Tests might need to create CameraCharacteristicsCompat directly for convenience. Elsewhere
      * we should get the CameraCharacteristicsCompat instance from {@link CameraManagerCompat}.
      */
-    @VisibleForTesting(otherwise = VisibleForTesting.PACKAGE_PRIVATE)
+    @VisibleForTesting
     @NonNull
     public static CameraCharacteristicsCompat toCameraCharacteristicsCompat(
             @NonNull CameraCharacteristics characteristics, @NonNull String cameraId) {

compose/animation/animation-core/src/commonMain/kotlin/androidx/compose/animation/core/Animation.kt

@@ -108,7 +108,6 @@ fun <T, V : AnimationVector> Animation<T, V>.getVelocityFromNanos(playTimeNanos:
  * @param initialVelocity the initial velocity to start the animation at
  * @suppress
  */
-/*@VisibleForTesting(otherwise = PACKAGE_PRIVATE)*/
 fun <V : AnimationVector> VectorizedAnimationSpec<V>.createAnimation(
     initialValue: V,
     targetValue: V,

compose/animation/animation-core/src/commonMain/kotlin/androidx/compose/animation/core/SpringEstimation.kt

@@ -26,7 +26,6 @@ import kotlin.math.sqrt
  * Returns the estimated time that the spring will last be at [delta]
  * @suppress
  */
-/*@VisibleForTesting(otherwise = VisibleForTesting.PACKAGE_PRIVATE)*/
 fun estimateAnimationDurationMillis(
     stiffness: Float,
     dampingRatio: Float,
@@ -45,7 +44,6 @@ fun estimateAnimationDurationMillis(
  * Returns the estimated time that the spring will last be at [delta]
  * @suppress
  */
-/*@VisibleForTesting(otherwise = VisibleForTesting.PACKAGE_PRIVATE)*/
 fun estimateAnimationDurationMillis(
     stiffness: Double,
     dampingRatio: Double,
@@ -69,7 +67,6 @@ fun estimateAnimationDurationMillis(
  * Returns the estimated time that the spring will last be at [delta]
  * @suppress
  */
-/*@VisibleForTesting(otherwise = VisibleForTesting.PACKAGE_PRIVATE)*/
 fun estimateAnimationDurationMillis(
     springConstant: Double,
     dampingCoefficient: Double,

compose/ui/ui-test-junit4/src/androidMain/kotlin/androidx/compose/ui/test/junit4/ComposeRootRegistry.android.kt

@@ -61,7 +61,7 @@ internal class ComposeRootRegistry {
     /**
      * Cleans up the changes made by [setupRegistry]. Call this after your test has run.
      */
-    @VisibleForTesting(otherwise = VisibleForTesting.PRIVATE)
+    @VisibleForTesting
     internal fun tearDownRegistry() {
         synchronized(lock) {
             // Stop accepting new roots

compose/ui/ui-test-junit4/src/jvmMain/kotlin/androidx/compose/ui/test/junit4/IdlingResourceRegistry.jvm.kt

@@ -27,7 +27,7 @@ import kotlinx.coroutines.delay
 import kotlinx.coroutines.launch
 
 internal class IdlingResourceRegistry
-@VisibleForTesting(otherwise = VisibleForTesting.PRIVATE)
+@VisibleForTesting
 @InternalTestApi
 internal constructor(
     private val pollScopeOverride: CoroutineScope?