Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Update vulnerability attestation to match new ITE-9 implementation #1242

Open
pxp928 opened this issue Sep 8, 2023 · 4 comments
Open
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@pxp928
Copy link
Collaborator

pxp928 commented Sep 8, 2023

Is your feature request related to a problem? Please describe.

Currently, we are using our own version to attest to vulnerability information. A formal vulnerability predicate has been created by the in-toto community that we should instead switch to.

Describe the solution you'd like

Once the protobuf is defined in the upstream in-toto attestations repo, we can use that to replace the current temporary vulnerability attestation we have been using.

The existing and new predicates are very similar but the new predicate contains extra fields (such as vulnerability score) that we need to capture.

This requires a change to both the osv ceritifier and vulnerability parser to capture the added information (such as vulnerability score) into GUAC

@pxp928 pxp928 added the enhancement New feature or request label Sep 8, 2023
@pxp928 pxp928 added the good first issue Good for newcomers label Feb 5, 2024
@rakshitgondwal
Copy link
Contributor

Hey @pxp928, I'd like to have a go at this!

@pxp928
Copy link
Collaborator Author

pxp928 commented Apr 26, 2024

Hey @rakshitgondwal sure thing but the vuln predicate type proto definition PR has not been merged yet: in-toto/attestation#345. Once it has been, that would be great to transition over.

In the meantime, you can take a look at another issue that you would like to work on. Thank You!

@rakshitgondwal
Copy link
Contributor

Sure, thank you @pxp928

@lumjjb
Copy link
Contributor

lumjjb commented Oct 9, 2024

Hi @rakshitgondwal ! I was wondering if you were still looking into this? I happened to have some vuln predicates ready for ingestion :). Would be awesome to see this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants