Skip to content

Commit 30ad1f8

Browse files
Merge pull request #373 from sudo-hannes/update-force-all-finite-to-ensure-all-finite
Replace deprecated force_all_finite parameter and update scikit-learn version requirement
2 parents 5b2be3d + a313fea commit 30ad1f8

File tree

16 files changed

+29
-29
lines changed

16 files changed

+29
-29
lines changed

README.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ OptBinning requires
8181
* ortools (>=9.4)
8282
* pandas
8383
* ropwr (>=1.0.0)
84-
* scikit-learn (>=1.0.2)
84+
* scikit-learn (>=1.6.0)
8585
* scipy (>=1.6.0)
8686

8787
OptBinning[distributed] requires additional packages

optbinning/binning/binning.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -793,7 +793,7 @@ def _fit(self, x, y, sample_weight, check_input):
793793
if self.dtype == "numerical":
794794
user_splits = check_array(
795795
self.user_splits, ensure_2d=False, dtype=None,
796-
force_all_finite=True)
796+
ensure_all_finite=True)
797797

798798
if len(set(user_splits)) != len(user_splits):
799799
raise ValueError("User splits are not unique.")

optbinning/binning/binning_process.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1085,10 +1085,10 @@ def _fit(self, X, y, sample_weight, check_input):
10851085
# check X and y data
10861086
if check_input:
10871087
X = check_array(X, ensure_2d=False, dtype=None,
1088-
force_all_finite='allow-nan')
1088+
ensure_all_finite='allow-nan')
10891089

10901090
y = check_array(y, ensure_2d=False, dtype=None,
1091-
force_all_finite=True)
1091+
ensure_all_finite=True)
10921092

10931093
check_consistent_length(X, y)
10941094

optbinning/binning/continuous_binning.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -642,7 +642,7 @@ def _fit(self, x, y, sample_weight, check_input):
642642
if self.dtype == "numerical":
643643
user_splits = check_array(
644644
self.user_splits, ensure_2d=False, dtype=None,
645-
force_all_finite=True)
645+
ensure_all_finite=True)
646646

647647
if len(set(user_splits)) != len(user_splits):
648648
raise ValueError("User splits are not unique.")

optbinning/binning/mdlp.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -99,8 +99,8 @@ def fit(self, x, y):
9999
def _fit(self, x, y):
100100
_check_parameters(**self.get_params())
101101

102-
x = check_array(x, ensure_2d=False, force_all_finite=True)
103-
y = check_array(y, ensure_2d=False, force_all_finite=True)
102+
x = check_array(x, ensure_2d=False, ensure_all_finite=True)
103+
y = check_array(y, ensure_2d=False, ensure_all_finite=True)
104104

105105
idx = np.argsort(x)
106106
x = x[idx]

optbinning/binning/metrics.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@
1414

1515

1616
def _check_x_y(x, y):
17-
x = check_array(x, ensure_2d=False, force_all_finite=True)
18-
y = check_array(y, ensure_2d=False, force_all_finite=True)
17+
x = check_array(x, ensure_2d=False, ensure_all_finite=True)
18+
y = check_array(y, ensure_2d=False, ensure_all_finite=True)
1919

2020
check_consistent_length(x, y)
2121

optbinning/binning/multiclass_binning.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -565,7 +565,7 @@ def _fit(self, x, y, check_input):
565565
.format(n_splits))
566566

567567
user_splits = check_array(self.user_splits, ensure_2d=False,
568-
dtype=None, force_all_finite=True)
568+
dtype=None, ensure_all_finite=True)
569569

570570
if len(set(user_splits)) != len(user_splits):
571571
raise ValueError("User splits are not unique.")

optbinning/binning/multidimensional/preprocessing_2d.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,13 +53,13 @@ def split_data_2d(dtype_x, dtype_y, x, y, z, special_codes_x=None,
5353
"""
5454
if check_input:
5555
x = check_array(x, ensure_2d=False, dtype=None,
56-
force_all_finite='allow-nan')
56+
ensure_all_finite='allow-nan')
5757

5858
y = check_array(y, ensure_2d=False, dtype=None,
59-
force_all_finite='allow-nan')
59+
ensure_all_finite='allow-nan')
6060

6161
z = check_array(z, ensure_2d=False, dtype=None,
62-
force_all_finite=True)
62+
ensure_all_finite=True)
6363

6464
check_consistent_length(x, y, z)
6565

optbinning/binning/multidimensional/transformations_2d.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -121,10 +121,10 @@ def transform_binary_target(dtype_x, dtype_y, splits_x, splits_y, x, y,
121121

122122
if check_input:
123123
x = check_array(x, ensure_2d=False, dtype=None,
124-
force_all_finite='allow-nan')
124+
ensure_all_finite='allow-nan')
125125

126126
y = check_array(y, ensure_2d=False, dtype=None,
127-
force_all_finite='allow-nan')
127+
ensure_all_finite='allow-nan')
128128

129129
x = np.asarray(x)
130130
y = np.asarray(y)
@@ -198,10 +198,10 @@ def transform_continuous_target(dtype_x, dtype_y, splits_x, splits_y, x, y,
198198

199199
if check_input:
200200
x = check_array(x, ensure_2d=False, dtype=None,
201-
force_all_finite='allow-nan')
201+
ensure_all_finite='allow-nan')
202202

203203
y = check_array(y, ensure_2d=False, dtype=None,
204-
force_all_finite='allow-nan')
204+
ensure_all_finite='allow-nan')
205205

206206
x = np.asarray(x)
207207
y = np.asarray(y)

optbinning/binning/piecewise/transformations.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ def transform_binary_target(splits, x, c, lb, ub, n_nonevent, n_event,
7272

7373
if check_input:
7474
x = check_array(x, ensure_2d=False, dtype=None,
75-
force_all_finite='allow-nan')
75+
ensure_all_finite='allow-nan')
7676

7777
x = np.asarray(x)
7878

@@ -144,7 +144,7 @@ def transform_continuous_target(splits, x, c, lb, ub, n_records_special,
144144

145145
if check_input:
146146
x = check_array(x, ensure_2d=False, dtype=None,
147-
force_all_finite='allow-nan')
147+
ensure_all_finite='allow-nan')
148148

149149
x = np.asarray(x)
150150

0 commit comments

Comments
 (0)