From 041599c0b32bbd8cd543a1b91393df76dfb3e53b Mon Sep 17 00:00:00 2001 From: Aleyna Akyuz Date: Mon, 21 Oct 2024 15:50:13 -0400 Subject: [PATCH 1/2] Adding warning for no injections --- pycbc/strain/strain.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pycbc/strain/strain.py b/pycbc/strain/strain.py index 4ff3b01d061..1e6d9e9bff0 100644 --- a/pycbc/strain/strain.py +++ b/pycbc/strain/strain.py @@ -318,6 +318,8 @@ def from_cli(opt, dyn_range_fac=1, precision='single', distance_scale=opt.injection_scale_factor, injection_sample_rate=opt.injection_sample_rate, inj_filter_rejector=inj_filter_rejector) + else: + logger.warning("No injections applied.") if opt.sgburst_injection_file: logger.info("Applying sine-Gaussian burst injections") From 20e7fc845a195727044dbcd3cbad9d2b0571040e Mon Sep 17 00:00:00 2001 From: Aleyna Akyuz Date: Tue, 3 Dec 2024 11:57:33 -0500 Subject: [PATCH 2/2] Changing where we raised the warning --- pycbc/inject/inject.py | 1 + pycbc/strain/strain.py | 2 -- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/pycbc/inject/inject.py b/pycbc/inject/inject.py index 1e15c692df8..32b99ada34b 100644 --- a/pycbc/inject/inject.py +++ b/pycbc/inject/inject.py @@ -568,6 +568,7 @@ def apply(self, strain, detector_name, f_lower=None, distance_scale=1, # safety buffer start_time = inj.tc - 2 * (inj_length + 1) if end_time < t0 or start_time > t1: + logger.warning("No injections applied.") continue signal = self.make_strain_from_inj_object(inj, delta_t, detector_name, f_lower=f_l, diff --git a/pycbc/strain/strain.py b/pycbc/strain/strain.py index 1e6d9e9bff0..4ff3b01d061 100644 --- a/pycbc/strain/strain.py +++ b/pycbc/strain/strain.py @@ -318,8 +318,6 @@ def from_cli(opt, dyn_range_fac=1, precision='single', distance_scale=opt.injection_scale_factor, injection_sample_rate=opt.injection_sample_rate, inj_filter_rejector=inj_filter_rejector) - else: - logger.warning("No injections applied.") if opt.sgburst_injection_file: logger.info("Applying sine-Gaussian burst injections")